Closed Bug 1315256 Opened 3 years ago Closed 3 years ago

Wasm baseline: Clean up platform ifdefs, part 2: the slightly harder cases

Categories

(Core :: JavaScript Engine: JIT, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: lth, Assigned: lth)

Details

Attachments

(2 files)

Additional ifdef cleanup.  It is possible to do more than this but apart from load and store (bug 1312751) I don't think it will pay off enough to worry about.
Add a stub for arm64, so that we can get rid of an ifdef in the compiler.
Attachment #8807550 - Flags: review?(hv1989)
Miscellaneous cleanup.

I did change some names, notably the "QUOT_REM" thing is gone in favor of "INT_DIV" since I use IntDiv as a suffix for some other names.  Also some other rearrangement for clarification makes this patch a little bloated.
Attachment #8807551 - Flags: review?(hv1989)
Comment on attachment 8807550 [details] [diff] [review]
bug1315256-arm64-stub.patch

Review of attachment 8807550 [details] [diff] [review]:
-----------------------------------------------------------------

Should the removal of the ifdef be part of this patch?
Attachment #8807550 - Flags: review?(hv1989) → review+
Comment on attachment 8807551 [details] [diff] [review]
bug1315256-cleanup.patch

Review of attachment 8807551 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanups.

::: js/src/wasm/WasmBaselineCompile.cpp
@@ +2948,5 @@
>  # else
>          MOZ_CRASH("BaseCompiler platform hook: convertI64ToF64");
>  # endif
>      }
> +#endif // I64_TO_FLOAT_CALLOUT

Good call. I failed to say anything about this in previous reviews.
Attachment #8807551 - Flags: review?(hv1989) → review+
Try run is a little colorful because of an unused variable and warnings-as-errors, but otherwise OK:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=360737fd4844&selectedJob=30540259
https://hg.mozilla.org/mozilla-central/rev/3c814c9606ff
https://hg.mozilla.org/mozilla-central/rev/02620bbac092
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.