1315256 - Wasm baseline: Clean up platform ifdefs, part 2: the slightly harder cases

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P2)

Description

[Lars T Hansen [:lth]]

Additional ifdef cleanup.  It is possible to do more than this but apart from load and store (bug 1312751) I don't think it will pay off enough to worry about.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1315256-arm64-stub.patch

Add a stub for arm64, so that we can get rid of an ifdef in the compiler.

Comment 2

[Lars T Hansen [:lth]]

Attachment: bug1315256-cleanup.patch

Miscellaneous cleanup.

I did change some names, notably the "QUOT_REM" thing is gone in favor of "INT_DIV" since I use IntDiv as a suffix for some other names.  Also some other rearrangement for clarification makes this patch a little bloated.

Comment 3

[Hannes Verschore [:h4writer]]

Comment on attachment 8807550 [details] [diff] [review]
bug1315256-arm64-stub.patch

Review of attachment 8807550 [details] [diff] [review]:
-----------------------------------------------------------------

Should the removal of the ifdef be part of this patch?

Comment 4

[Hannes Verschore [:h4writer]]

Comment on attachment 8807551 [details] [diff] [review]
bug1315256-cleanup.patch

Review of attachment 8807551 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanups.

::: js/src/wasm/WasmBaselineCompile.cpp
@@ +2948,5 @@
>  # else
>          MOZ_CRASH("BaseCompiler platform hook: convertI64ToF64");
>  # endif
>      }
> +#endif // I64_TO_FLOAT_CALLOUT

Good call. I failed to say anything about this in previous reviews.

Comment 5

[Lars T Hansen [:lth]]

Try run is a little colorful because of an unused variable and warnings-as-errors, but otherwise OK:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=360737fd4844&selectedJob=30540259

Comment 6

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c814c9606ffc356e5c34571d1745e33781f445f
Bug 1315256 - Add branch64 stub for arm64 to benefit wasm baseline. r=h4writer

https://hg.mozilla.org/integration/mozilla-inbound/rev/02620bbac0928ad8f75b37dd3c0de458c7ddfe15
Bug 1315256 - Wasm baseline: clean up more ifdefs. r=h4writer

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3c814c9606ff
https://hg.mozilla.org/mozilla-central/rev/02620bbac092