Closed Bug 1315263 Opened 4 years ago Closed 4 years ago

Add a way to skip shlibsign in gyp build

Categories

(NSS :: Build, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

We do this during packaging for Firefox builds.
Attachment #8807553 - Flags: review?(franziskuskiefer)
Comment on attachment 8807553 [details] [diff] [review]
add a sign_libs variable

Review of attachment 8807553 [details] [diff] [review]:
-----------------------------------------------------------------

Since when do we skip this for FF? We might have to do it again when we decide to do FIPS again...
Attachment #8807553 - Flags: review?(franziskuskiefer) → review+
We do it as part of packaging, not during the build. (Except on OS X, where .app signing requirements changed at some point and we can't put the files next to the binaries anymore.)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.