1315264 - Minimizing or maximizing the window with a stylus throws black lines on www.addtext.com when Pointer Events is preffed on

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Alexandru Simonca [:asimonca], Release Desktop QA]

Attachment: lines on firefox with pen.mp4

[Affected versions]:
- Nightly 52.0a1

[Affected platforms]:
- Windows 10 x64

[Steps to reproduce]:
Make sure that the build has e10s enabled and the pref "browser.tabs.remote.force-enable" set to "true".

1. Go to about:config and set the "dom.w3c_pointer_events.enabled" preff to "true"
2. Go to www.addtext.com
3. Tap on the "Restore down / maximize" button next to the "X" / "Close" one with a stylus.

[Expected result]:
- The window is minimized or maximized accordingly.

[Actual result]:
- The window is minimized / maximized but there are black lines thrown to the Firefox window.

[Regression range]:
- This is not a regression since this is a new feature.

[Additional notes]:
- This issue is not reproducible by mouse or touch, only by stylus and only with Pointer Events preffed on.

- Please see the URL section for a detailed screenshot of the issue.

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Set InkCollector.AutoRedraw to false to prevent repainting when the window is invalidated

Comment 2

[Ming-Chou Shih [:stone]]

The easier way to reproduce this problem is dragging the Window with pen after drawing something (with pen) on the Window. The pen path will be redrawn when the window is invalidated.

Comment 3

[Ming-Chou Shih [:stone]]

Attachment: Bug 1315264: Set InkCollector.AutoRedraw to false to prevent repainting when the window is invalidated.

Review commit: https://reviewboard.mozilla.org/r/96216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96216/

Comment 4

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96b1765aca095ecc2826d90485299c15762d84a8

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8815190 [details]
Bug 1315264: Set InkCollector.AutoRedraw to false to prevent repainting when the window is invalidated.

https://reviewboard.mozilla.org/r/96216/#review97506

Comment 6

[Cynthia Tang [:cynthiatang]]

Hi stone,
This issue can be reproduced in Windows7. Thank you.

Version: Firefox 53.0a1(2016-12-27)

Comment 7

[Ming-Chou Shih [:stone]]

Comment on attachment 8815190 [details]
Bug 1315264: Set InkCollector.AutoRedraw to false to prevent repainting when the window is invalidated.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96216/diff/1-2/

Comment 8

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e801b82dc38609ebb9e88208f98417e0d2f48d9c

Comment 9

[Carsten Book [:Tomcat]]

landed as https://hg.mozilla.org/integration/autoland/rev/141fe3b986cd80d7781545b24413462735c76545 (not sure why the bot failed to comment_

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/141fe3b986cd

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Is it something we should uplift to 52? I have difficulty to see the impact

Comment 12

[Ming-Chou Shih [:stone]]

It only happens when users turn on pointer event preference and operate FF with a stylus on Windows. After drawing something on FF with the stylus and trigger window to be repainted (ex. drag the window, maximize, or minimize the window), the drawn lines will be shown on FF (then disappeared)