1315269 - The default action button in PopupNotification prompts should follow platform conventions

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The redesigned popup notifications always show the default action on the right, which matches platform convention on macOS & Linux. Windows always puts the default action on the left and UX (maritz, bwinton & shorlander) says we should respect that.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: button-order-fix.patch

Here is how this could work, but I'm hoping there is a simpler solution that doesn't involve the preprocessor.

Comment 2

[Matthew N. [:MattN]]

Would https://developer.mozilla.org/en-US/docs/Web/CSS/box-ordinal-group work for this?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Maybe it will. Paolo suggested using flex order:

https://developer.mozilla.org/en-US/docs/Web/CSS/order

If anyone can give either of these a try that would be awesome, because I don't know when I'll be able to get back at this.

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Reverse notification buttons on Windows to follow platform conventions

This is an approach using flex-direction. Note that I haven't tested on actual Windows yet because my VM is still compiling. I'll also push a mozscreenshots build. Let's see what's faster.

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af759bf01ad0

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Make sure you test the identity prompt that has the drop down arrow on the right of the secondary button.

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Reverse notification buttons on Windows to follow platform conventions

Good point, this should work better!

Comment 8

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=687f3dd27d54

Comment 9

[Johann Hofmann [:johannh]]

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=5f5e46d71cbf98eb61db0e5e934fd5ed7efc6109&newProject=try&newRev=31e13d0b22647e1a6895c48f35f63281f67c5840

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8811262 [details] [diff] [review]
Reverse notification buttons on Windows to follow platform conventions

Review of attachment 8811262 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, assuming it works as expected in the password prompt as well.

Comment 11

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/248955c8a9cb68c2a97c103366af6d073e3bc2e0
Bug 1315269 - Reverse notification buttons on Windows to follow platform conventions. r=past

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/248955c8a9cb

Comment 14

[Sylvestre Ledru [:Sylvestre]]

I guess we want this to ride the train with 53

Comment 15

[Johann Hofmann [:johannh]]

Yup, I don't think this was ever relevant for 52 :)

Comment 16

[Paul Silaghi, QA [:pauly]]

Confirmed the default action:
- on the right on Ubuntu 14.04, OS X 10.11.
- on the left on Win 7
Verified fixed Fx 53.0a2 (2017-02-03).