Use correct API for opening a source in the debugger

RESOLVED FIXED in Firefox 52

Status

P1
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: jlong, Assigned: jlong)

Tracking

unspecified
Firefox 52

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1313197 introduced a regression because we don't call the right debugger API. Will fix here and make sure a test covers it.
(Assignee)

Comment 1

2 years ago
Created attachment 8807709 [details] [diff] [review]
1315289.patch

This fixes it and also re-enables the test to make sure we don't break it again.
Attachment #8807709 - Flags: review?(jlaster)
(Assignee)

Updated

2 years ago
Assignee: nobody → jlong
Priority: -- → P1
Comment on attachment 8807709 [details] [diff] [review]
1315289.patch

Review of attachment 8807709 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #8807709 - Flags: review?(jlaster) → review+

Comment 4

2 years ago
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2acfe066887
Use correct API for opening a source in the debugger r=me

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e2acfe066887
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.