Closed Bug 1315335 Opened 8 years ago Closed 8 years ago

JSON parse errors should be exposed in New Release UI

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (frontend)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rail, Assigned: F3real)

References

Details

I tried to create a new release using a file with malformed JSON. The UI wasn't showing anything wrong, but I found that the console was complaining. We should probably expose JSON parse errors in the UI.
Stefan, are you able to follow-up on this? It's a bit of a rough edge introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1301066.
Flags: needinfo?(stefan92f)
I'll look into it.
Flags: needinfo?(stefan92f)
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/5a76e64fdf03c87aedb4dc9a9dcf47faf64b8d65
bug 1315335: JSON parse errors should be exposed in New Release UI (#177). r=bhearsum
Depends on: 1320966
This change will be deployed in bug 1320966 sometime between 11am and 1pm pacific on 2016-11-30. IT will be deployed to stage today. Can you verify your fixes once stage is deployed please?
Flags: needinfo?(bhearsum)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #4)
> This change will be deployed in bug 1320966 sometime between 11am and 1pm
> pacific on 2016-11-30. IT will be deployed to stage today. Can you verify
> your fixes once stage is deployed please?

Yep, working in stage.
Flags: needinfo?(bhearsum)
This is in production now. Thanks Stefan!
Assignee: nobody → stefan92f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.