1315348 - Rotating the device while viewing a custom tab loses toolbar color

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Dylan Roeh (:droeh) (he/him)]

Open a custom tab and change the device orientation. The toolbar becomes grey, when it should retain the custom color from the intent (if applicable).

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Preserve toolbar color/title through orientation changes

This turned out to be an easy enough fix: just preserve the color and title in onSaveInstanceState and restore them in onCreate.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8808385 [details] [diff] [review]
Preserve toolbar color/title through orientation changes

Review of attachment 8808385 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
@@ +5,5 @@
>  
>  package org.mozilla.gecko.customtabs;
>  
> +import android.graphics.drawable.ColorDrawable;
> +

nit: Empty line between android.* imports

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7eda3bfe63
Handle orientation changes in CustomTabsActivity without losing toolbar color or title. r=sebastian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d7eda3bfe63

Comment 5

[Sorina Florean [:sflorean]]

Verified as fixed in Build 57.0b9 and 58.0a1.
Devices: Mototola Nexus 6 (Android 7.1.1) and Sony Xperia Z5 Premium (Android 6.0.1).
Rotating a device to landscape/portrait when CustomTab activity is launched doesn't change the toolbar color.