Rotating the device while viewing a custom tab loses toolbar color

VERIFIED FIXED in Firefox 52

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
8 months ago

People

(Reporter: droeh, Assigned: droeh)

Tracking

unspecified
Firefox 52
All
Android
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Open a custom tab and change the device orientation. The toolbar becomes grey, when it should retain the custom color from the intent (if applicable).
(Assignee)

Comment 1

2 years ago
Created attachment 8808385 [details] [diff] [review]
Preserve toolbar color/title through orientation changes

This turned out to be an easy enough fix: just preserve the color and title in onSaveInstanceState and restore them in onCreate.
Attachment #8808385 - Flags: review?(s.kaspari)
Comment on attachment 8808385 [details] [diff] [review]
Preserve toolbar color/title through orientation changes

Review of attachment 8808385 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
@@ +5,5 @@
>  
>  package org.mozilla.gecko.customtabs;
>  
> +import android.graphics.drawable.ColorDrawable;
> +

nit: Empty line between android.* imports
Attachment #8808385 - Flags: review?(s.kaspari) → review+

Comment 3

2 years ago
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7eda3bfe63
Handle orientation changes in CustomTabsActivity without losing toolbar color or title. r=sebastian

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d7eda3bfe63
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Verified as fixed in Build 57.0b9 and 58.0a1.
Devices: Mototola Nexus 6 (Android 7.1.1) and Sony Xperia Z5 Premium (Android 6.0.1).
Rotating a device to landscape/portrait when CustomTab activity is launched doesn't change the toolbar color.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.