Closed Bug 1315359 Opened 7 years ago Closed 7 years ago

Simplify custom tabs onBackPressed behavior

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

Attachments

(1 file)

Refactor GeckoApp.onBackPressed
5.45 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
A slight refactoring of GeckoApp.onBackPressed would let us use it for CustomTabsActivity.onBackPressed instead of maintaining two very similar implementations.
Factor the moveTaskToBack() calls out of onBackPressed so that they can be replaced by finish() calls by CustomTabsActivity.
Attachment #8807703 - Flags: review?(snorp)
Attachment #8807703 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81f2a2b396f8
Refactor GeckoApp.onBackPressed to allow it to be used by both GeckoApp and CustomTabsActivity. r=snorp
https://hg.mozilla.org/mozilla-central/rev/81f2a2b396f8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.