Closed Bug 1315359 Opened 4 years ago Closed 4 years ago

Simplify custom tabs onBackPressed behavior

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

Attachments

(1 file)

A slight refactoring of GeckoApp.onBackPressed would let us use it for CustomTabsActivity.onBackPressed instead of maintaining two very similar implementations.
Factor the moveTaskToBack() calls out of onBackPressed so that they can be replaced by finish() calls by CustomTabsActivity.
Attachment #8807703 - Flags: review?(snorp)
Attachment #8807703 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81f2a2b396f8
Refactor GeckoApp.onBackPressed to allow it to be used by both GeckoApp and CustomTabsActivity. r=snorp
https://hg.mozilla.org/mozilla-central/rev/81f2a2b396f8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.