1315394 - stylo: stop unconditionally marking the root node as dirty in PresShell::Init

Status: RESOLVED DUPLICATE of bug 1317016

(Core :: CSS Parsing and Computation, defect)

Description

[Bobby Holley (:bholley)]

Currently we do this because of the issue in bug 1292280, where nsDocumentViewer::SetPageMode recreates the presshell for an existing document. However, it's nonsensical in the new incremental restyle model, where the concept of dirtiness doesn't exist. I think we can handle it by simply dropping all the servo data in SetPageMode.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1315394 - stylo: stop unconditionally marking the root node as dirty in PresShell::Init. v1

MozReview-Commit-ID: 66gJWIZl0wo

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a4ace26b70bf527d0aa8c384ad80d1da1ac122

Comment 3

[Bobby Holley (:bholley)]

Review ping?

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8807772 [details] [diff] [review]
Bug 1315394 - stylo: stop unconditionally marking the root node as dirty in PresShell::Init. v1

Review of attachment 8807772 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, overlooked the review request.

Would be nice if there were a more direct way of doing this (dropping the ServoNodeData from everything in the tree), but I guess this works too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41f004509646
stylo: stop unconditionally marking the root node as dirty in PresShell::Init. r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Android crashtests started asserting like https://treeherder.mozilla.org/logviewer.html#?job_id=39062528&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd08d5a029d

Comment 7

[Bobby Holley (:bholley)]

I'm just going to roll this into bug 1317016.