Closed Bug 1315394 Opened 3 years ago Closed 3 years ago

stylo: stop unconditionally marking the root node as dirty in PresShell::Init

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED DUPLICATE of bug 1317016

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Currently we do this because of the issue in bug 1292280, where nsDocumentViewer::SetPageMode recreates the presshell for an existing document. However, it's nonsensical in the new incremental restyle model, where the concept of dirtiness doesn't exist. I think we can handle it by simply dropping all the servo data in SetPageMode.
Review ping?
Flags: needinfo?(cam)
Comment on attachment 8807772 [details] [diff] [review]
Bug 1315394 - stylo: stop unconditionally marking the root node as dirty in PresShell::Init. v1

Review of attachment 8807772 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, overlooked the review request.

Would be nice if there were a more direct way of doing this (dropping the ServoNodeData from everything in the tree), but I guess this works too.
Attachment #8807772 - Flags: review?(cam) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41f004509646
stylo: stop unconditionally marking the root node as dirty in PresShell::Init. r=heycam
I'm just going to roll this into bug 1317016.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bobbyholley)
Resolution: --- → DUPLICATE
Duplicate of bug: 1317016
Flags: needinfo?(cam)
You need to log in before you can comment on or make changes to this bug.