Closed Bug 1315402 Opened 8 years ago Closed 8 years ago

Fix no-undef failures in toolkit/mozapps/update

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Version:
3 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(3 files)

Bug 1315402: Detect more head files for tests automatically.
58 bytes, text/x-review-board-request
standard8
: review+
jryans
: review+
Details
Bug 1315402: Make toolkit/mozapps/update pass no-undef.
58 bytes, text/x-review-board-request
jaws
: review+
Details
Additional changes after tooltool upload
66.30 KB, patch
Details | Diff | Splinter Review 
      No description provided.
Attachment #8807788 - Flags: review?(standard8)
Attachment #8807789 - Flags: review?(jaws)
Attachment #8807788 - Flags: review?(standard8)
Attachment #8807789 - Flags: review?(jaws)
Depends on: 1315805
Attachment #8807788 - Flags: review?(jryans)
Comment on attachment 8807788 [details]
Bug 1315402: Detect more head files for tests automatically.

https://reviewboard.mozilla.org/r/90806/#review91342

Packaging changes look good to me.  I'll attach a patch for you fold with the tooltool changes.
Attachment #8807788 - Flags: review?(jryans) → review+
Please fold this into your patch that changes the ESLint dependencies.  You should be able to do a try run with this added in.
Comment on attachment 8807789 [details]
Bug 1315402: Make toolkit/mozapps/update pass no-undef.

https://reviewboard.mozilla.org/r/90808/#review90960
Attachment #8807789 - Flags: review?(jaws) → review+
Comment on attachment 8807788 [details]
Bug 1315402: Detect more head files for tests automatically.

https://reviewboard.mozilla.org/r/90806/#review91364

Nice!
Attachment #8807788 - Flags: review?(standard8) → review+
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/677db8d8c837
Detect more head files for tests automatically. r=standard8, r=jryans
https://hg.mozilla.org/integration/mozilla-inbound/rev/02876b8cf2b0
Make toolkit/mozapps/update pass no-undef. r=jaws
https://hg.mozilla.org/mozilla-central/rev/677db8d8c837
https://hg.mozilla.org/mozilla-central/rev/02876b8cf2b0
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: