1315410 - Isolate artifact build perfherder metrics

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Perfherder metrics for artifact builds are writing to the same metrics as non-artifact builds. This makes the data bi-modal.

We should write artifact build metrics to a separate bucket.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1315410 - Isolate perfherder metrics by build type;

Currently, artifact build metrics go to the same bucket as non-artifact
build metrics. This results in bi-modal metrics.

In this commit, we introduce a "perfherder_extra_options" config
value which is concatenated with the auto-derived values. We change
the artifact build mozharness configs to add "artifact" to denote them
as such.

I'm not keen on adding more functionality to mozharness. But this is
easier than having BuildMixin read state from the build system. I also
like the easy extensibility of this mechanism.

Review commit: https://reviewboard.mozilla.org/r/90824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90824/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8807799 [details]
Bug 1315410 - Isolate perfherder metrics by build type;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90824/diff/1-2/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8807799 [details]
Bug 1315410 - Isolate perfherder metrics by build type;

https://reviewboard.mozilla.org/r/90824/#review93490

::: testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_opt.py:28
(Diff revision 2)
>      'tooltool_script': ["/builds/tooltool.py"],
>      'tooltool_bootstrap': "setup.sh",
>      'enable_count_ctors': True,
>      'enable_talos_sendchange': False,
>      'enable_unittest_sendchange': False,
> +    'perfherder_extra_options': ['st-an'],

I know we use `st-an` elsewhere, but could we just use `static-analysis` here to be clearer?

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8807799 [details]
Bug 1315410 - Isolate perfherder metrics by build type;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90824/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2244cd429374
Isolate perfherder metrics by build type; r=ted

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2244cd429374