Add min and max values to app update integer values configured by preferences as appropriate
RESOLVED
FIXED
in Firefox 52
Status
()
People
(Reporter: rstrong, Assigned: rstrong)
Tracking
Firefox Tracking Flags
(firefox52 fixed)
Details
Attachments
(2 attachments, 3 obsolete attachments)
|
21.21 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
|
28.28 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
There are already a few of these and I'm going to add a few more as appropriate to prevent accidental changes as well as add-ons from breaking app update.
|
(Assignee) | |
Updated•2 years ago
|
Priority: -- → P2
|
|
(Assignee) | |
Comment 1•2 years ago
|
||
Created attachment 8808901 [details] [diff] [review] patch in progress - tests
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
Created attachment 8808902 [details] [diff] [review] patch in progress - client
|
|
(Assignee) | |
Comment 3•2 years ago
|
||
Created attachment 8809193 [details] [diff] [review] client patch
Attachment #8808901 -
Attachment is obsolete: true
Attachment #8808902 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 4•2 years ago
|
||
Created attachment 8809194 [details] [diff] [review] test patch
|
|
(Assignee) | |
Comment 5•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=98728e920829dd9a33c7a80826933d4f9c76b910
|
|
(Assignee) | |
Comment 6•2 years ago
|
||
Created attachment 8809259 [details] [diff] [review] Firefox prefs patch
Attachment #8809259 -
Flags: review?(felipc)
|
|
(Assignee) | |
Updated•2 years ago
|
Attachment #8809193 -
Flags: review?(mhowell)
|
|
(Assignee) | |
Comment 7•2 years ago
|
||
Comment on attachment 8809194 [details] [diff] [review] test patch There is a little unrelated cleanup in the patches as well.
Attachment #8809194 -
Flags: review?(mhowell)
|
||
Updated•2 years ago
|
Attachment #8809193 -
Flags: review?(mhowell) → review+
|
|
||
Updated•2 years ago
|
Attachment #8809194 -
Flags: review?(mhowell) → review+
|
|
(Assignee) | |
Comment 8•2 years ago
|
||
Comment on attachment 8809259 [details] [diff] [review] Firefox prefs patch The prefs patch isn't important for this effort so I'm going to move it to a new bug.
Attachment #8809259 -
Attachment is obsolete: true
Attachment #8809259 -
Flags: review?(felipc)
|
|
(Assignee) | |
Comment 9•2 years ago
|
||
Filed bug 1316621 for the Firefox preference cleanup
|
||
Comment 10•2 years ago
|
||
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8db63d1c00cf client code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/70b739aa2d6a test code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8db63d1c00cf https://hg.mozilla.org/mozilla-central/rev/70b739aa2d6a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•