Closed
Bug 1315505
Opened 6 years ago
Closed 6 years ago
Add min and max values to app update integer values configured by preferences as appropriate
Categories
(Toolkit :: Application Update, defect, P2)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(2 files, 3 obsolete files)
21.21 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
28.28 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
There are already a few of these and I'm going to add a few more as appropriate to prevent accidental changes as well as add-ons from breaking app update.
![]() |
Assignee | |
Updated•6 years ago
|
Priority: -- → P2
![]() |
Assignee | |
Comment 1•6 years ago
|
||
![]() |
Assignee | |
Comment 2•6 years ago
|
||
![]() |
Assignee | |
Comment 3•6 years ago
|
||
Attachment #8808901 -
Attachment is obsolete: true
Attachment #8808902 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 4•6 years ago
|
||
![]() |
Assignee | |
Comment 5•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=98728e920829dd9a33c7a80826933d4f9c76b910
![]() |
Assignee | |
Comment 6•6 years ago
|
||
Attachment #8809259 -
Flags: review?(felipc)
![]() |
Assignee | |
Updated•6 years ago
|
Attachment #8809193 -
Flags: review?(mhowell)
![]() |
Assignee | |
Comment 7•6 years ago
|
||
Comment on attachment 8809194 [details] [diff] [review] test patch There is a little unrelated cleanup in the patches as well.
Attachment #8809194 -
Flags: review?(mhowell)
Updated•6 years ago
|
Attachment #8809193 -
Flags: review?(mhowell) → review+
Updated•6 years ago
|
Attachment #8809194 -
Flags: review?(mhowell) → review+
![]() |
Assignee | |
Comment 8•6 years ago
|
||
Comment on attachment 8809259 [details] [diff] [review] Firefox prefs patch The prefs patch isn't important for this effort so I'm going to move it to a new bug.
Attachment #8809259 -
Attachment is obsolete: true
Attachment #8809259 -
Flags: review?(felipc)
![]() |
Assignee | |
Comment 9•6 years ago
|
||
Filed bug 1316621 for the Firefox preference cleanup
Comment 10•6 years ago
|
||
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8db63d1c00cf client code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/70b739aa2d6a test code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8db63d1c00cf https://hg.mozilla.org/mozilla-central/rev/70b739aa2d6a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•