Closed Bug 1315505 Opened 4 years ago Closed 4 years ago

Add min and max values to app update integer values configured by preferences as appropriate

Categories

(Toolkit :: Application Update, defect, P2)

Product:
Toolkit
Component:
Application Update
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(2 files, 3 obsolete files)

client patch
21.21 KB, patch
mhowell
: review+
Details | Diff | Splinter Review
test patch
28.28 KB, patch
mhowell
: review+
Details | Diff | Splinter Review 
There are already a few of these and I'm going to add a few more as appropriate to prevent accidental changes as well as add-ons from breaking app update.
Priority: -- → P2
Attached patch client patch — — Splinter Review
Attachment #8808901 - Attachment is obsolete: true
Attachment #8808902 - Attachment is obsolete: true
Attached patch Firefox prefs patch (obsolete) — — Splinter Review
Attachment #8809259 - Flags: review?(felipc)
Attachment #8809193 - Flags: review?(mhowell)
Comment on attachment 8809194 [details] [diff] [review]
test patch

There is a little unrelated cleanup in the patches as well.
Attachment #8809194 - Flags: review?(mhowell)
Attachment #8809193 - Flags: review?(mhowell) → review+
Attachment #8809194 - Flags: review?(mhowell) → review+
Comment on attachment 8809259 [details] [diff] [review]
Firefox prefs patch

The prefs patch isn't important for this effort so I'm going to move it to a new bug.
Attachment #8809259 - Attachment is obsolete: true
Attachment #8809259 - Flags: review?(felipc)
Filed bug 1316621 for the Firefox preference cleanup
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8db63d1c00cf
client code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/70b739aa2d6a
test code for Bug 1315505 - Add min and max values to app update integer values configured by preferences as appropriate to prevent prefs from breaking app update. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/8db63d1c00cf
https://hg.mozilla.org/mozilla-central/rev/70b739aa2d6a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.