1315506 - Remove app.update.url.override preference

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Robert Strong (they/them - no direct email)]

This test preference has been abused in the real world so another method should be used for testing when the entire url needs to be modified.

Comment 1

[Robert Strong (they/them - no direct email)]

Henrik, heads up that the app.update.url.override preference will be removed in the very near future. Instead of using this preference the app.update.url default preference should be used. Please adjust your tests accordingly.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks for the information ahead of time. I assume it means that this value has to be set before Firefox gets started, or we need an additional restart. Is that correct?

Comment 3

[Robert Strong (they/them - no direct email)]

No, you can set default preferences from code and the value is not cached.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I see. I will file a separate bug to work on this once the related pref is no longer available.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: B2G marionette tests

I could remove these but the b2g community is still using app update and this change is trivial.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch - tests

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch - client

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=68b26b964a57f7dac70d435b1c37ba88498a74da

Comment 9

[Robert Strong (they/them - no direct email)]

Ben and Nick, just a heads up that the app.update.url.override preference will be removed soonish... likely Friday afternoon Mountain View time.

Comment 10

[[e-mail] (:bhearsum)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> No, you can set default preferences from code and the value is not cached.

When you say "from code" does this mean that it's not possible to change app.update.url without building Firefox? Or is there some way to change it with an addon or some such?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ben, please see comment 3. I assume that would help you too.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Henrik Skupin (:whimboo) from comment #11)
> Ben, please see comment 3. I assume that would help you too.

That's what I replied to. I don't understand what "set default preferences from code" means, though.

Comment 13

[Robert Strong (they/them - no direct email)]

Youcan set the value of the default preference from code running in Firefox. There are examples within the first two patches.

Comment 14

[Robert Strong (they/them - no direct email)]

Attachment: patch - tests rev2

Removed to additional instances where test configs were trying to use this pref to disable updates but were a noop.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b333ba0fdd87
marionette tests fixes - Bug 1315506 - Remove app.update.url.override preference. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/993e106e331f
test code for Bug 1315506 - Remove app.update.url.override preference. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/355cce73963e
client code for Bug 1315506 - Remove app.update.url.override preference. r=mhowell

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b333ba0fdd87
https://hg.mozilla.org/mozilla-central/rev/993e106e331f
https://hg.mozilla.org/mozilla-central/rev/355cce73963e

Comment 17

[Mike Kaply [:mkaply]]

We need to update the docs.

https://developer.mozilla.org/en-US/docs/Mozilla/Setting_up_an_update_server

Comment 18

[Robert Strong (they/them - no direct email)]

I've added a simple update to the page though it might be good if someone provided examples of setting default prefs. Not sure if that page is used all that often though.

Comment 19

[Mark Smith [:mcs]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #18)
> I've added a simple update to the page though it might be good if someone
> provided examples of setting default prefs. Not sure if that page is used
> all that often though.

Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?

Comment 20

[Mike Kaply [:mkaply]]

> Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?

It can also be via autoconfig or defaults/prefs.

But you are correct, no way for the user to set default prefs (I guess via scratchpad)

Comment 21

[[e-mail] (:bhearsum)]

(In reply to Mike Kaply [:mkaply] from comment #20)
> > Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?
> 
> It can also be via autoconfig or defaults/prefs.
> 
> But you are correct, no way for the user to set default prefs (I guess via
> scratchpad)

It doesn't look like it works from default/prefs/channel-prefs.js, for what it's worth.

Comment 22

[[e-mail] (:bhearsum)]

(In reply to Mike Kaply [:mkaply] from comment #17)
> We need to update the docs.
> 
> https://developer.mozilla.org/en-US/docs/Mozilla/Setting_up_an_update_server

I updated this doc with updated instructions for using a custom update server.

Comment 23

[Mike Kaply [:mkaply]]

> It doesn't look like it works from default/prefs/channel-prefs.js, for what it's worth.

I've verified it does work from Autoconfig.

Comment 24

[Nicolas Vigier]

This wiki page probably needs an update as it is still using app.update.url.override:
https://wiki.mozilla.org/Software_Update:HowToTestMajorUpdateUI