Closed Bug 1315506 Opened 3 years ago Closed 3 years ago

Remove app.update.url.override preference

Categories

(Toolkit :: Application Update, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

(Keywords: dev-doc-needed)

Attachments

(3 files, 1 obsolete file)

This test preference has been abused in the real world so another method should be used for testing when the entire url needs to be modified.
Henrik, heads up that the app.update.url.override preference will be removed in the very near future. Instead of using this preference the app.update.url default preference should be used. Please adjust your tests accordingly.
Flags: needinfo?(hskupin)
Thanks for the information ahead of time. I assume it means that this value has to be set before Firefox gets started, or we need an additional restart. Is that correct?
Flags: needinfo?(hskupin)
No, you can set default preferences from code and the value is not cached.
I see. I will file a separate bug to work on this once the related pref is no longer available.
I could remove these but the b2g community is still using app update and this change is trivial.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8809541 - Flags: review?(mhowell) → review+
Attachment #8809540 - Flags: review?(mhowell) → review+
Attachment #8809539 - Flags: review?(mhowell) → review+
Ben and Nick, just a heads up that the app.update.url.override preference will be removed soonish... likely Friday afternoon Mountain View time.
Flags: needinfo?(nthomas)
Flags: needinfo?(bhearsum)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> No, you can set default preferences from code and the value is not cached.

When you say "from code" does this mean that it's not possible to change app.update.url without building Firefox? Or is there some way to change it with an addon or some such?
Flags: needinfo?(bhearsum)
Ben, please see comment 3. I assume that would help you too.
(In reply to Henrik Skupin (:whimboo) from comment #11)
> Ben, please see comment 3. I assume that would help you too.

That's what I replied to. I don't understand what "set default preferences from code" means, though.
Youcan set the value of the default preference from code running in Firefox. There are examples within the first two patches.
Removed to additional instances where test configs were trying to use this pref to disable updates but were a noop.
Attachment #8809540 - Attachment is obsolete: true
Attachment #8809935 - Flags: review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b333ba0fdd87
marionette tests fixes - Bug 1315506 - Remove app.update.url.override preference. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/993e106e331f
test code for Bug 1315506 - Remove app.update.url.override preference. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/355cce73963e
client code for Bug 1315506 - Remove app.update.url.override preference. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/b333ba0fdd87
https://hg.mozilla.org/mozilla-central/rev/993e106e331f
https://hg.mozilla.org/mozilla-central/rev/355cce73963e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Flags: needinfo?(nthomas)
I've added a simple update to the page though it might be good if someone provided examples of setting default prefs. Not sure if that page is used all that often though.
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #18)
> I've added a simple update to the page though it might be good if someone
> provided examples of setting default prefs. Not sure if that page is used
> all that often though.

Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?
> Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?

It can also be via autoconfig or defaults/prefs.

But you are correct, no way for the user to set default prefs (I guess via scratchpad)
(In reply to Mike Kaply [:mkaply] from comment #20)
> > Just to confirm: setting default prefs must be done from an extension or other privileged code, correct?
> 
> It can also be via autoconfig or defaults/prefs.
> 
> But you are correct, no way for the user to set default prefs (I guess via
> scratchpad)

It doesn't look like it works from default/prefs/channel-prefs.js, for what it's worth.
(In reply to Mike Kaply [:mkaply] from comment #17)
> We need to update the docs.
> 
> https://developer.mozilla.org/en-US/docs/Mozilla/Setting_up_an_update_server

I updated this doc with updated instructions for using a custom update server.
> It doesn't look like it works from default/prefs/channel-prefs.js, for what it's worth.

I've verified it does work from Autoconfig.
This wiki page probably needs an update as it is still using app.update.url.override:
https://wiki.mozilla.org/Software_Update:HowToTestMajorUpdateUI
You need to log in before you can comment on or make changes to this bug.