1315551 - "tab-sound-icon" is not shown in tab

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/c44c01dfd264370c1558b747525d220a9a89b51c
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 ID:20161106030203


Reproducible: 100%

Steps To Reproduce:
1. Open https://videos.cdn.mozilla.net/uploads/mozillaorg/
2. Click any video link


Actual Results:
"tab-sound-icon" is not shown in tab

Expected Results:
"tab-sound-icon" should be shown in tab



Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c22b06e7fba4a0c6bf4c1fdf451ebf52633b6767&tochange=10d414508e1798890cbe04007a726c80a6dc7514

Regressed by: Bug 1302350

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1315551 - part1 : should pass valid window for agent's initialization.

Review commit: https://reviewboard.mozilla.org/r/90996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90996/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function.

Review commit: https://reviewboard.mozilla.org/r/90998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90998/

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1315551 - part3 : check we have initialized agent when we want to call the agent's function.

Review commit: https://reviewboard.mozilla.org/r/91000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91000/

Comment 4

[Marcia Knous [:marcia]]

Tracking 52+ for this visual regression.

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8808073 [details]
Bug 1315551 - part1 : should pass valid window for agent's initialization.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90996/diff/1-2/

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8808074 [details]
Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90998/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8808073 [details]
Bug 1315551 - part1 : should pass valid window for agent's initialization.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90996/diff/2-3/

Comment 8

[Alastor Wu [:alwu]]

Comment on attachment 8808074 [details]
Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90998/diff/2-3/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8808074 [details]
Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function.

https://reviewboard.mozilla.org/r/90998/#review91096

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 8808073 [details]
Bug 1315551 - part1 : should pass valid window for agent's initialization.

https://reviewboard.mozilla.org/r/90996/#review91152

This is ok if we don't have telephony API. I remember that telephony API doesn't set a window.

Comment 11

[Alastor Wu [:alwu]]

(In reply to Andrea Marchesini [:baku] from comment #10)
> Comment on attachment 8808073 [details]
> Bug 1315551 - part1 : should pass valid window for agent's initialization.
> 
> https://reviewboard.mozilla.org/r/90996/#review91152
> 
> This is ok if we don't have telephony API. I remember that telephony API
> doesn't set a window.

Yes, telephony API is b2g-only and it has been removed from m-c.

Comment 12

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3df6c506773f0f308b88abc0778e2248d185c1e&selectedJob=30558264

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/967dd79df01c
part1 : should pass valid window for agent's initialization. r=baku
https://hg.mozilla.org/integration/autoland/rev/dd2c93bc1da3
part2 : check we have initialized agent when we want to call the agent's function. r=jwwang

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/967dd79df01c
https://hg.mozilla.org/mozilla-central/rev/dd2c93bc1da3

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 52.0a1, build ID: 20161106030203, on Windows 10 x64.
I can confirm this issue is fixes, I verified using Fx 52.0b4, build ID: 20170206101855, on Windows 10 x64, Mac OS X 10.11 and Ubuntu 14.04 LTS.

Cheers!