Closed Bug 1315632 Opened 7 years ago Closed 7 years ago

stylo: leave old style on frames when nsChangeHint_ReconstructFrame was generated

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Bug 1315632 - stylo: Leave old style on frames when nsChangeHint_ReconstructFrame was generated.
58 bytes, text/x-review-board-request
emilio
: review+
Details 
The Gecko RestyleManager leaves the old style on a frame if we generate an nsChangeHint_ReconstructFrame for it or an ancestor.  Some frame constructor code needs the old style on there.  The test in the patch I'll attach is an example of this, where to find the right list to remove the old frame from, nsLayoutUtils::GetChildListNameFor needs to have the old value of the position property.
Blocks: stylo
Comment on attachment 8808103 [details]
Bug 1315632 - stylo: Leave old style on frames when nsChangeHint_ReconstructFrame was generated.

https://reviewboard.mozilla.org/r/91034/#review90774
Attachment #8808103 - Flags: review?(ecoal95) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3a6dadbb885
stylo: Leave old style on frames when nsChangeHint_ReconstructFrame was generated. r=emilio
https://hg.mozilla.org/mozilla-central/rev/c3a6dadbb885
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.