Clean up: simplify unnecessary loop

RESOLVED FIXED in Firefox 52

Status

()

P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla52
coverity
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [CID 1394251])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Coverity found out that a loop's top in MBinaryBitwiseInstruction::foldUnnecessaryBitop was unreachable. According to the comment right above, it's expected, but let's make this clear by not having a loop at all.
(Assignee)

Updated

2 years ago
Keywords: coverity
Whiteboard: [CID 1394251]
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8808112 [details]
Bug 1315640: Split unnecessary loop into linear code;

https://reviewboard.mozilla.org/r/91038/#review90778

Good catch.
Attachment #8808112 - Flags: review?(nicolas.b.pierron) → review+

Comment 4

2 years ago
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/750b9537efcd
Split unnecessary loop into linear code; r=nbp
Priority: -- → P5

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/750b9537efcd
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.