1315640 - Clean up: simplify unnecessary loop

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Coverity found out that a loop's top in MBinaryBitwiseInstruction::foldUnnecessaryBitop was unreachable. According to the comment right above, it's expected, but let's make this clear by not having a loop at all.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1315640: Split unnecessary loop into linear code;

Review commit: https://reviewboard.mozilla.org/r/91038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91038/

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e8a0bc6c4b just in case

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8808112 [details]
Bug 1315640: Split unnecessary loop into linear code;

https://reviewboard.mozilla.org/r/91038/#review90778

Good catch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/750b9537efcd
Split unnecessary loop into linear code; r=nbp

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/750b9537efcd