Closed Bug 1315640 Opened 3 years ago Closed 3 years ago

Clean up: simplify unnecessary loop

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1394251])

Attachments

(1 file)

Coverity found out that a loop's top in MBinaryBitwiseInstruction::foldUnnecessaryBitop was unreachable. According to the comment right above, it's expected, but let's make this clear by not having a loop at all.
Keywords: coverity
Whiteboard: [CID 1394251]
Comment on attachment 8808112 [details]
Bug 1315640: Split unnecessary loop into linear code;

https://reviewboard.mozilla.org/r/91038/#review90778

Good catch.
Attachment #8808112 - Flags: review?(nicolas.b.pierron) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/750b9537efcd
Split unnecessary loop into linear code; r=nbp
Priority: -- → P5
https://hg.mozilla.org/mozilla-central/rev/750b9537efcd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.