1315657 - Linux webplatform tests are broken on Taskcluster

Status: RESOLVED INVALID

(Release Engineering :: Applications: MozharnessCore, defect, P1)

Description

[Wander Lairson Costa]

https://treeherder.mozilla.org/#/jobs?repo=autolandrevision=6228dfcfac3bacb413f4e979ba4d3c79bc8b9509

Comment 1

[Wander Lairson Costa]

Attachment: Bug 1315657: Fix web-platform tests for Linux o Taskcluster.

Docker image for Linux tests ships minidump-stack-walk. The mozharness
script finds it instead of tooltool downloaded file, and when try to
give executable permission, it gets permission denied error because the
file is localted outside home directory. As minidump-stack-walk already
has executable permission, we skip the permission denied error.

Review commit: https://reviewboard.mozilla.org/r/91058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91058/

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8808147 [details]
Bug 1315657: Fix web-platform tests for Linux o Taskcluster.

https://reviewboard.mozilla.org/r/91058/#review90792

hijacking

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89783fd81e5
Fix web-platform tests for Linux o Taskcluster. r=rail

Comment 4

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8808147 [details]
Bug 1315657: Fix web-platform tests for Linux o Taskcluster.

https://reviewboard.mozilla.org/r/91058/#review90798

::: testing/mozharness/mozharness/mozilla/testing/testbase.py:769
(Diff revision 1)
> +                    # docker image for Linux tests on Taskcluster already
> +                    # ship minidump stackwalk. If mozharness finds it, it
> +                    # won't have permission to modify bits. It is harmless,
> +                    # however, because it already has executable permission.
> +                    if e.errno != errno.EPERM:
> +                        raise

Hey Wander,

I think it would be better to check if it is executable, rather than checking the error condition afterwards, and assuming error permission => previously installed *and* exectuable.

The reason for this is, maybe it exists on the environment, the user does not have permission to chmod it, but it is also not executable - then we would not be covered. The assumption that if it exists but we couldn't change the permissions means that it was already executable could be wrong (maybe it exists but isn't executable) - therefore I think it would be better to explicitly check whether it is executable.

It is up to you if you want to chmod proactively before checking, or check whether it is not executable, and then only chmod if needed. The advantage of the first is it probably is atomic, however the second is perhaps cheaper as it doesn't require a filesystem write in the case it is already executable(?). Either way, at the end you want to be sure it is executable, so we should check that.

Thanks Wander!

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5de5a3e2d82
Backed out changeset d89783fd81e5

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed for taskcluster marionette bustage, see bug 1274980 comment 135.

Comment 7

[Wander Lairson Costa]

Closing this because it should be fixed with reworked patches on bug 1274980