Closed Bug 1315675 Opened 3 years ago Closed 3 years ago

browser_oneOffContextMenu_setDefault.js will be permafail when trunk merges to aurora

Categories

(Firefox :: Search, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 + fixed

People

(Reporter: cbook, Assigned: standard8)

References

()

Details

Attachments

(1 file)

from uplift simulations: https://treeherder.mozilla.org/logviewer.html#?job_id=30469981&repo=try

 TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffContextMenu_setDefault.js | One-off for test engine should exist - "undefined" != "undefined" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_oneOffContextMenu_setDefault.js :: openPopupAndGetEngineButton :: line 158 

we need to fix this before trunk merges to aurora to avoid perma failures and tree closures
[Tracking Requested - why for this release]:

perma failure on trunk as aurora simulations - also per irc needinfo to mark :)
Flags: needinfo?(standard8)
also we have https://treeherder.mozilla.org/logviewer.html#?job_id=30475595&repo=try

 13:45:14 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser_UsageTelemetry_urlbar.js | browser.engagement.navigation.urlbar must contain the 'search_oneoff' key. - false == true - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: checkKeyedScalar :: line 52 

that seems related
Taking.
Assignee: nobody → standard8
Flags: needinfo?(standard8)
Comment on attachment 8808613 [details]
Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches.

https://reviewboard.mozilla.org/r/91416/#review91618
Attachment #8808613 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab7ed6880d3
Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak
https://hg.mozilla.org/mozilla-central/rev/2ab7ed6880d3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.