If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

browser_oneOffContextMenu_setDefault.js will be permafail when trunk merges to aurora

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Search
--
critical
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: Tomcat, Assigned: standard8)

Tracking

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52+ fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
from uplift simulations: https://treeherder.mozilla.org/logviewer.html#?job_id=30469981&repo=try

 TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffContextMenu_setDefault.js | One-off for test engine should exist - "undefined" != "undefined" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_oneOffContextMenu_setDefault.js :: openPopupAndGetEngineButton :: line 158 

we need to fix this before trunk merges to aurora to avoid perma failures and tree closures
(Reporter)

Comment 1

11 months ago
[Tracking Requested - why for this release]:

perma failure on trunk as aurora simulations - also per irc needinfo to mark :)
status-firefox52: --- → affected
tracking-firefox52: --- → ?
Flags: needinfo?(standard8)
(Reporter)

Comment 2

11 months ago
also we have https://treeherder.mozilla.org/logviewer.html#?job_id=30475595&repo=try

 13:45:14 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser_UsageTelemetry_urlbar.js | browser.engagement.navigation.urlbar must contain the 'search_oneoff' key. - false == true - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: checkKeyedScalar :: line 52 

that seems related
tracking-firefox52: ? → +
(Assignee)

Comment 3

11 months ago
Taking.
Assignee: nobody → standard8
Flags: needinfo?(standard8)
Comment hidden (mozreview-request)

Comment 5

11 months ago
mozreview-review
Comment on attachment 8808613 [details]
Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches.

https://reviewboard.mozilla.org/r/91416/#review91618
Attachment #8808613 - Flags: review?(mak77) → review+

Comment 6

11 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab7ed6880d3
Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak
(Reporter)

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ab7ed6880d3
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.