1315706 - Change the CompositorWidget::PreRender/PostRender signatures to not require a LayerManagerComposite

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Going forward with WebRender means that we may not have a LayerManagerComposite in some cases, but we (probably) still need to call PreRender/PostRender, because the cocoa widget at least does useful things there.

Seeing as the cocoa widget just needs a GL context from the LayerManagerComposite, and the android widget just needs to set the GL clear color on the compositor, and neither of them really need a LayerManagerComposite specifically, we can replace that argument with a new struct that contains platform-specific fields.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

DrawWindowUnderlay/Overlay also don't need any parameters. android is the only widget that uses these functions, and the arguments have not been used for a while.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions.

This is the first step in using these functions without having a
LayerManagerComposite at all, which we will need to do as part of the
WebRender integration work.

Review commit: https://reviewboard.mozilla.org/r/91164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91164/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> DrawWindowUnderlay/Overlay also don't need any parameters. android is the
> only widget that uses these functions, and the arguments have not been used
> for a while.

I was wrong about this, cocoa implements DrawWindowOverlay. So I updated those functions also take the WidgetRenderContext.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Shoot, I forgot to update WinCompositorWidget. I did that locally and am rebuilding to verify it compiles.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8808334 [details]
Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91164/diff/1-2/

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8808334 [details]
Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions.

https://reviewboard.mozilla.org/r/91164/#review91066

It'd be nice to do this without #ifdefs, but the #ifdefs are such a small part of the code that I doubt it's worth it yet.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Yeah if we start needing this in more places we can look into removing the ifdefs and using some sort of widget-specific subclass instead.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd859148673c
Pass a wrapper struct to various CompositorWidget functions. r=dvander

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd859148673c