Visual feedback when clicking highlights

RESOLVED FIXED in Firefox 52

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: ahunt)

Tracking

unspecified
Firefox 52
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

Currently we show no visual feedback when highlights are clicked.

The material approach would be to show a ripple effect:
https://material.google.com/motion/material-motion.html#material-motion-how-does-material-move

However there's usually a system resource (background drawable) that we could use.
Priority: -- → P2
Whiteboard: [MobileAS]
Assignee

Updated

3 years ago
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request)
Iteration: --- → 1.8
Reporter

Comment 2

3 years ago
mozreview-review
Comment on attachment 8808673 [details]
Bug 1315716 - Use selectableItemBackground for material ripple on ActivityStream cards

https://reviewboard.mozilla.org/r/91444/#review91914

Ah, much nicer :D
Attachment #8808673 - Flags: review?(s.kaspari) → review+

Comment 3

3 years ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2ea3980ed5d
Use selectableItemBackground for material ripple on ActivityStream cards r=sebastian

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a2ea3980ed5d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.