1315717 - Visual feedback when clicking menu button (highlights)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

See bug 1315716. Our menu button also does not show any visual feedback when pressing.

Comment 1

[Andrzej Hunt :ahunt]

The rounded version (https://developer.android.com/reference/android/R.attr.html#selectableItemBackgroundBorderless) which is probably better, is API 21+.

My current plan is to therefore use the old (rectangular version) on 4.0, and upgrade on 5+ - that still results in nicer behaviour on 4, while 5+ look more material'y.

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button

The ripple added using selectableItemBackgroundBorderless is scaled to the actual View area.
By rearranging our margins+padding we are able to make the empty space around the menu button
part of its padding, which results in a more naturally sized ripple. Without this
patch the circular ripple is tiny and looks odd.

Review commit: https://reviewboard.mozilla.org/r/91448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91448/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5

The circular ripple is only available on API >= 21. We can fallback to a different solution
for older devices, see following patch.

Review commit: https://reviewboard.mozilla.org/r/91450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91450/

Comment 4

[Andrzej Hunt :ahunt]

Attachment: Bug 1315717 - Enable old rectangular feedback for Android 4 devices

Review commit: https://reviewboard.mozilla.org/r/91452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91452/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8808674 [details]
Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button

https://reviewboard.mozilla.org/r/91448/#review91974

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8808675 [details]
Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5

https://reviewboard.mozilla.org/r/91450/#review92040

::: mobile/android/base/java/org/mozilla/gecko/util/MaterialUtil.java:13
(Diff revision 1)
> +import android.view.View;
> +
> +import org.mozilla.gecko.AppConstants;
> +import org.mozilla.gecko.R;
> +
> +public class MaterialUtil {

I wonder if we should transform this in a more generic ViewUtil class?

::: mobile/android/base/java/org/mozilla/gecko/util/MaterialUtil.java:19
(Diff revision 1)
> +     * You should also set "android:background="?android:attr/selectableItemBackground" in the layout
> +     * to provide a square touch ripple on older devices.

Isn't this something this method could do for me for older devices automatically?

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8808676 [details]
Bug 1315717 - Enable old rectangular feedback for Android 4 devices

https://reviewboard.mozilla.org/r/91452/#review92050

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8808674 [details]
Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91448/diff/1-2/

Comment 9

[Andrzej Hunt :ahunt]

Comment on attachment 8808675 [details]
Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91450/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1c1918210f7
Pre: rearrange higlights padding to increase area for menu button r=sebastian
https://hg.mozilla.org/integration/autoland/rev/86d2e155758c
Add ripple feedback to AS context menu buttons on Android >= 5 r=sebastian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1c1918210f7
https://hg.mozilla.org/mozilla-central/rev/86d2e155758c