Closed Bug 1315717 Opened 3 years ago Closed 3 years ago

Visual feedback when clicking menu button (highlights)

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 52
Iteration:
1.8
Tracking Status
firefox52 --- fixed

People

(Reporter: sebastian, Assigned: ahunt)

References

Details

(Whiteboard: [MobileAS])

Attachments

(2 files, 1 obsolete file)

See bug 1315716. Our menu button also does not show any visual feedback when pressing.
Priority: -- → P2
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Priority: P2 → P1
The rounded version (https://developer.android.com/reference/android/R.attr.html#selectableItemBackgroundBorderless) which is probably better, is API 21+.

My current plan is to therefore use the old (rectangular version) on 4.0, and upgrade on 5+ - that still results in nicer behaviour on 4, while 5+ look more material'y.
Iteration: --- → 1.8
Comment on attachment 8808674 [details]
Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button

https://reviewboard.mozilla.org/r/91448/#review91974
Attachment #8808674 - Flags: review?(s.kaspari) → review+
Comment on attachment 8808675 [details]
Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5

https://reviewboard.mozilla.org/r/91450/#review92040

::: mobile/android/base/java/org/mozilla/gecko/util/MaterialUtil.java:13
(Diff revision 1)
> +import android.view.View;
> +
> +import org.mozilla.gecko.AppConstants;
> +import org.mozilla.gecko.R;
> +
> +public class MaterialUtil {

I wonder if we should transform this in a more generic ViewUtil class?

::: mobile/android/base/java/org/mozilla/gecko/util/MaterialUtil.java:19
(Diff revision 1)
> +     * You should also set "android:background="?android:attr/selectableItemBackground" in the layout
> +     * to provide a square touch ripple on older devices.

Isn't this something this method could do for me for older devices automatically?
Attachment #8808675 - Flags: review?(s.kaspari) → review+
Comment on attachment 8808676 [details]
Bug 1315717 - Enable old rectangular feedback for Android 4 devices

https://reviewboard.mozilla.org/r/91452/#review92050
Attachment #8808676 - Flags: review?(s.kaspari) → review+
Attachment #8808676 - Attachment is obsolete: true
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1c1918210f7
Pre: rearrange higlights padding to increase area for menu button r=sebastian
https://hg.mozilla.org/integration/autoland/rev/86d2e155758c
Add ripple feedback to AS context menu buttons on Android >= 5 r=sebastian
https://hg.mozilla.org/mozilla-central/rev/f1c1918210f7
https://hg.mozilla.org/mozilla-central/rev/86d2e155758c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.