Closed Bug 1315794 Opened 5 years ago Closed 5 years ago
Update about:debugging to be compatible with React 15
58 bytes, text/x-review-board-request
Blocker for Bug 1312236. about:debugging uses React.render and React.unmountComponentAtNode which have been deprecated in favor of their ReactDOM counterpart. Some tests are also failing due because React no longer updates text nodes in the same way as it used to, our mutationObservers are no longer triggered.
try build on top of React 15.3.2 : https://treeherder.mozilla.org/#/jobs?repo=try&revision=9418d35224805beb8ee2d574687754965d1d0f95 try build on top of current mc : https://treeherder.mozilla.org/#/jobs?repo=try&revision=28382644c1248847dc8b65b25c636b8f986a7cc8
Comment on attachment 8808371 [details] Bug 1315794 - migrate aboutdebugging to React 15.3.2; https://reviewboard.mozilla.org/r/91190/#review91228 LGTM, thanks!
Attachment #8808371 - Flags: review?(lclark) → review+
Thanks for the review Lin! Try runs look good: all green on top of mc ; no aboutdebugging failure for the other one. Landing.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c8bca2404d0b migrate aboutdebugging to React 15.3.2;r=linclark
You need to log in before you can comment on or make changes to this bug.