Closed Bug 1315794 Opened 4 years ago Closed 4 years ago

Update about:debugging to be compatible with React 15.3.2

Categories

(DevTools :: about:debugging, defect, P2)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Blocker for Bug 1312236.

about:debugging uses React.render and React.unmountComponentAtNode which have been deprecated in favor of their ReactDOM counterpart.

Some tests are also failing due because React no longer updates text nodes in the same way as it used to, our mutationObservers are no longer triggered.
Blocks: 1312236
Comment on attachment 8808371 [details]
Bug 1315794 - migrate aboutdebugging to React 15.3.2;

https://reviewboard.mozilla.org/r/91190/#review91228

LGTM, thanks!
Attachment #8808371 - Flags: review?(lclark) → review+
Thanks for the review Lin! 

Try runs look good: all green on top of mc ; no aboutdebugging failure for the other one. Landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8bca2404d0b
migrate aboutdebugging to React 15.3.2;r=linclark
https://hg.mozilla.org/mozilla-central/rev/c8bca2404d0b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.