Update about:debugging to be compatible with React 15.3.2

RESOLVED FIXED in Firefox 52

Status

defect
P2
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

Trunk
Firefox 52
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Blocker for Bug 1312236.

about:debugging uses React.render and React.unmountComponentAtNode which have been deprecated in favor of their ReactDOM counterpart.

Some tests are also failing due because React no longer updates text nodes in the same way as it used to, our mutationObservers are no longer triggered.
Assignee

Updated

3 years ago
Blocks: 1312236
Comment hidden (mozreview-request)

Comment 3

3 years ago
mozreview-review
Comment on attachment 8808371 [details]
Bug 1315794 - migrate aboutdebugging to React 15.3.2;

https://reviewboard.mozilla.org/r/91190/#review91228

LGTM, thanks!
Attachment #8808371 - Flags: review?(lclark) → review+
Assignee

Comment 4

3 years ago
Thanks for the review Lin! 

Try runs look good: all green on top of mc ; no aboutdebugging failure for the other one. Landing.

Comment 5

3 years ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8bca2404d0b
migrate aboutdebugging to React 15.3.2;r=linclark

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8bca2404d0b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.