1315794 - Update about:debugging to be compatible with React 15.3.2

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P2)

Description

[Julian Descottes [:jdescottes]]

Blocker for Bug 1312236.

about:debugging uses React.render and React.unmountComponentAtNode which have been deprecated in favor of their ReactDOM counterpart.

Some tests are also failing due because React no longer updates text nodes in the same way as it used to, our mutationObservers are no longer triggered.

Comment 1

[Julian Descottes [:jdescottes]]

try build on top of React 15.3.2 : https://treeherder.mozilla.org/#/jobs?repo=try&revision=9418d35224805beb8ee2d574687754965d1d0f95
try build on top of current mc : https://treeherder.mozilla.org/#/jobs?repo=try&revision=28382644c1248847dc8b65b25c636b8f986a7cc8

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1315794 - migrate aboutdebugging to React 15.3.2;

Use ReactDOM.render instead of React.render (same for unmountComponentAtNode)
Update tests to observe both childList and characterData mutations when
expecting only text changes.

Review commit: https://reviewboard.mozilla.org/r/91190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91190/

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8808371 [details]
Bug 1315794 - migrate aboutdebugging to React 15.3.2;

https://reviewboard.mozilla.org/r/91190/#review91228

LGTM, thanks!

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review Lin! 

Try runs look good: all green on top of mc ; no aboutdebugging failure for the other one. Landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8bca2404d0b
migrate aboutdebugging to React 15.3.2;r=linclark

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c8bca2404d0b