Closed Bug 1315796 Opened 3 years ago Closed 3 years ago
Group DEBUG validation code can try to use null docshell
In the TabGroupOuter() method there is some validation code. It can try to use a nullptr docshell causing weird behavior.
Comment on attachment 8808365 [details] [diff] [review] Don't deref nullptr docshell in TabGroupOuter() validation code. r=smaug http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#2065 http://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#13260 So, I think you should just check mIsChrome in the 'if'. No need to use docshell at all. with that, r+
Attachment #8808365 - Flags: review?(bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc00f40f2b6e Don't deref nullptr docshell in TabGroupOuter() validation code. r=smaug
You need to log in before you can comment on or make changes to this bug.