Closed
Bug 1315830
Opened 8 years ago
Closed 8 years ago
Remove unused nsIFileEnumerator program
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
3.35 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This seems to have been added back in 2000 as some sort of ad-hoc nsIFile test. There is now an actual gtest for nsIFile so this should be safe to remove. MozReview-Commit-ID: DMeVmBNmf8f
Assignee | ||
Comment 1•8 years ago
|
||
AFAICT this is unused. It's causing build errors on OSX now, I'm not exactly sure how it ever built. Given we already have a nsFile test I think we should just remove it.
Attachment #8808425 -
Flags: review?(nfroyd)
Comment 2•8 years ago
|
||
Is this still relevant in light of switching this to a GeckoSimpleProgram?
Flags: needinfo?(erahm)
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #2) > Is this still relevant in light of switching this to a GeckoSimpleProgram? Yes, that's just temporary.
Flags: needinfo?(erahm)
Comment 4•8 years ago
|
||
Comment on attachment 8808425 [details] [diff] [review] Remove unused nsIFileEnumerator program Review of attachment 8808425 [details] [diff] [review]: ----------------------------------------------------------------- This doesn't look particularly salvageable, since it relies on command-line arguments.
Attachment #8808425 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6a0b28b04e4b35494d15155f79e43cdc5244835 Bug 1315830 - Remove unused nsIFileEnumerator program. r=froydnj
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d6a0b28b04e4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•