Replace reference to JS::AutoIdArray in jsapi.h comment.

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: leper, Unassigned)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40
Build ID: 20160807101136

Steps to reproduce:

The comment for JS::Enumerate in jsapi.h suggests to use AutoIdArray, but that was removed in Bug 1191529, so the reference to it should be replaced by JS::Rooted<JS::IdVector>. Note that the comment was only added after AutoIdArray was already removed (Bug 1211607).
Reporter

Comment 1

3 years ago
Attachment #8808434 - Flags: review?(jorendorff)
Reporter

Updated

3 years ago
Version: unspecified → Trunk
Comment on attachment 8808434 [details] [diff] [review]
Replace reference to AutoIdArray by JS::Rooted<JS::IdVector>.

Review of attachment 8808434 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.

Thanks for fixing this!

::: js/src/jsapi.h
@@ +3208,5 @@
>   *
>   * This is the closest thing we currently have to the ES6 [[Enumerate]]
>   * internal method.
>   *
>   * The JSIdArray returned by JS_Enumerate must be rooted to protect its

Please replace "JSIdArray" with "array of IDs" or similar as this also doesn't exist any more.
Attachment #8808434 - Flags: review?(jorendorff) → review+
Blocks: 1191529
Reporter

Comment 3

3 years ago
Also replaced JSIdArray, thanks for the fast response.
Attachment #8808434 - Attachment is obsolete: true
Attachment #8808624 - Flags: review?(jcoppeard)
Comment on attachment 8808624 [details] [diff] [review]
Replace reference to AutoIdArray by JS::Rooted<JS::IdVector>. Also remove reference to JSIdArray.

Review of attachment 8808624 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks.
Attachment #8808624 - Flags: review?(jcoppeard) → review+
Reporter

Updated

3 years ago
Keywords: checkin-needed

Comment 5

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc62051be9c5
Replace reference to JS::AutoIdArray and JSIdArray. r=jonco
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc62051be9c5
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.