Closed Bug 1315862 Opened 8 years ago Closed 8 years ago

[Pointer Event] Stop dispatching pointer events in the system group

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: stone, Assigned: stone)

References

Details

Attachments

(2 files)

Spec [1] says preventDefault on pointerdown should cancel subsequent compatibility mouse events. Considering the case of canceling pointerdown by chrome, there are three possible handling.

1. mouse events shouldn't be canceled by preventDefault() by chrome
2. mouse events should be canceled with a call of preventDefault() even by chrome
3. mouse events should be canceled only on the nodes in chrome and/or in the system group

Now we implemented solution 1 and don't expect chrome use pointer events for default handling. See [2] for more details.

[1] https://w3c.github.io/pointerevents/#pointer-event-types
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1303704#c21
    https://bugzilla.mozilla.org/show_bug.cgi?id=1303704#c23
Blocks: 1303704
No longer blocks: 1303704
Depends on: 1303704
Assignee: nobody → sshih
Comment on attachment 8810760 [details]
Bug 1315862 Part1: Stop dispatching pointer events in the system group.

https://reviewboard.mozilla.org/r/93090/#review93388
Attachment #8810760 - Flags: review?(masayuki) → review+
Comment on attachment 8810760 [details]
Bug 1315862 Part1: Stop dispatching pointer events in the system group.

And I'd like smaug to check if this isn't different from the conclusion.
Attachment #8810760 - Flags: review?(bugs)
Comment on attachment 8810761 [details]
Bug 1315862 Part2: Add a test case to ensure pointer events aren't dispatched in the system group.

https://reviewboard.mozilla.org/r/93092/#review93392
Attachment #8810761 - Flags: review?(masayuki) → review+
Comment on attachment 8810760 [details]
Bug 1315862 Part1: Stop dispatching pointer events in the system group.

https://reviewboard.mozilla.org/r/93090/#review93674
Attachment #8810760 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/038de5add834
Part1: Stop dispatching pointer events in the system group. r=masayuki,smaug
https://hg.mozilla.org/integration/autoland/rev/d5a2a49e72d8
Part2: Add a test case to ensure pointer events aren't dispatched in the system group. r=masayuki
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/038de5add834
https://hg.mozilla.org/mozilla-central/rev/d5a2a49e72d8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: