Closed Bug 1315892 Opened 3 years ago Closed 3 months ago

'text-orientation: upright' should cause all characters to be treated as strong LTR

Categories

(Core :: Layout: Text and Fonts, defect, P3)

Product:
Core
Component:
Layout: Text and Fonts
Version:
52 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: kojii, Assigned: fantasai.bugs)

References

Details

Attachments

(2 files, 1 obsolete file)

completed patch
17.03 KB, patch
Details | Diff | Splinter Review
Bug 1315892 - 'text-orientation: upright' forces used 'direction' to LTR
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161107030203

Steps to reproduce:

5.1. Orienting Text: the text-orientation property states that "This value causes the used value of direction to be ltr, and for the purposes of bidi reordering, causes all characters to be treated as strong LTR."
https://drafts.csswg.org/css-writing-modes-3/#text-orientation

1. Run any of following tests
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vlr-003/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vlr-004/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vrl-003/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vrl-004/format/html5/


Actual results:

The Test Case tab does not match to the Reference Page tab.


Expected results:

The Test Case tab matches to the Reference Page tab.
chrome: http://crbug.com/663281
Component: Untriaged → Layout: Text
Product: Firefox → Core
https://github.com/w3c/csswg-drafts/issues/755 says:

Gecko implements partially, by inserting the RLO (the same effect as the workaround above) if the block has text-orientation: upright.

    It has the same restriction as above.
    It does not work when text-orientation: upright is applied to inline elements.
    It does not change the used value of direction, and therefore other effects (e.g., logical properties, table cell orders, etc.) is not included.
Priority: -- → P3
Assignee: nobody → fantasai.bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch patch for layout (obsolete) — — Splinter Review

This fixes the "used value of direction" aspect for layout (but not style resolution). It passes all reftests on tryserver.

Character-level handling appears to be working as expected, fwiw.

Attachment #9088350 - Attachment is patch: true
Attachment #9088350 - Attachment mime type: application/octet-stream → text/plain
Attached patch completed patch — — Splinter Review
Attachment #9088350 - Attachment is obsolete: true
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/8aeda7048e36
'text-orientation: upright' forces used 'direction' to LTR. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3a8c3658b9a2
Add a comment quoting the spec. r=me
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19070 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/8aeda7048e36
https://hg.mozilla.org/mozilla-central/rev/3a8c3658b9a2

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.