Various MIPS breakage

RESOLVED FIXED in Firefox 52

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla52
Other
All
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
While triaging some bugs I found that the shell would no longer compile with the MIPS simulators due to several unrelated reasons.  Some of these problems are mine (caused by the wasm baseline compiler or MacroAssembler refactoring); some are in the simulator.
(Assignee)

Comment 1

2 years ago
Created attachment 8808531 [details] [diff] [review]
bug1315901-wasm-baseline-mips.patch

Separate MIPS from ARM in Wasm baseline compiler setup because MIPS does not have the ARM scratch register (duh).
Attachment #8808531 - Flags: review?(nicolas.b.pierron)
(Assignee)

Comment 2

2 years ago
Created attachment 8808532 [details] [diff] [review]
bug1315901-masm-mips64.patch

When I refactored cmpPtrSet in bug 1268006 I neglected to move all the instantiations of that template for MIPS64.  (This is why templates are bad :)  So move them.
Attachment #8808532 - Flags: review?(nicolas.b.pierron)
(Assignee)

Comment 3

2 years ago
Created attachment 8808534 [details] [diff] [review]
bug1315901-mips-simulators.patch

Make MIPS simulators compile - mostly by fixing printf format strings - and reduce the warning volume a little by cleaning up a header file.
Attachment #8808534 - Flags: review?(r)
Comment on attachment 8808532 [details] [diff] [review]
bug1315901-masm-mips64.patch

Review of attachment 8808532 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/MacroAssembler-mips64-inl.h
@@ +411,5 @@
>  }
>  
> +template<>
> +inline void
> +MacroAssembler::cmpPtrSet(Assembler::Condition cond, Address lhs, ImmPtr rhs,

I do not think check_macroassembler_style works with template specializations yet.
Attachment #8808532 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8808531 - Flags: review?(nicolas.b.pierron) → review+

Comment 5

2 years ago
Comment on attachment 8808534 [details] [diff] [review]
bug1315901-mips-simulators.patch

Review of attachment 8808534 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Attachment #8808534 - Flags: review?(r) → review+

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0723acb2c137
https://hg.mozilla.org/mozilla-central/rev/7625f17309bf
https://hg.mozilla.org/mozilla-central/rev/560a32f9d49f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.