1315924 - GET MAP -button inactive / greyed out

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce with official DE SeaMonkey 2.49a1  (NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 Build 20161107002359  (Default Classic Theme) on German WIN7 64bit:

1. Launch SeaMonkey with browser → menu ˋWindow → Address Bookˊ
   » Address Book appears
2. In Address Books Pane select an Address book
3. Select (click) a contact entry with a complete address (streeet, town, 
   ... )
   » Details pane below contacts lists shows a [Get Map]
   Bug: Button is greyed out and inactive

a) Problem might be related to a new feature? in earlier SM versions 
   there was a simple button, now we hafe a complex button with
   additional ▼ Arrow Down, probably for alternative functions.
e) Safe Mode without addons does not heal the problem.

Comment 1

[Rainer Bielefeld]

@Stefan:
Can you confirm my problem

Comment 2

[Frank-Rainer Grahl (:frg)]

Hmm it looks like it was updated probably by TB without porting all changes / strings to SeaMonkey. Maybe this is the problem. rsx11m could you check it?


Timestamp: 11/19/2016 12:30:54 PM
Error: ReferenceError: goSetLabelAccesskeyTooltiptext is not defined
Source File: chrome://messenger/content/addressbook/abResultsPane.js
Line: 444

Timestamp: 11/19/2016 12:30:54 PM
Error: An error occurred updating the cmd_properties command: [Exception... "[JavaScript Error: "goSetLabelAccesskeyTooltiptext is not defined" {file: "chrome://messenger/content/addressbook/abResultsPane.js" line: 444}]'[JavaScript Error: "goSetLabelAccesskeyTooltiptext is not defined" {file: "chrome://messenger/content/addressbook/abResultsPane.js" line: 444}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 84"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 89

Comment 3

[rsx11m]

Bug 1310442 - Make labels of cmd_properties action-oriented and context-sensitive, e.g. "Edit Contact", "Edit List", etc. (consistent with improved dialogue titles from bug 1312262).

https://hg.mozilla.org/comm-central/rev/71581aa20801 only pushed strings for mail/ but not suite/.
Confirming per code review.

Comment 4

[rsx11m]

Bug 1310442 landed on 11/12 whereas the issue here was filed 11/08 already, makes me thinking that it's not quite the source for that specific regression. But anyway, we'll have to fix the suite/ strings, so maybe let's open a new bug for that and see to which extent it fixes the problem in this bug.

Comment 5

[:aceman]

Yeah comment 2 may be a different issue than comment 0.

Comment 6

[Rainer Bielefeld]

I did some tests with newly created user profile and imported addresses:

b1) Already reproducible withGerman SeaMonkey 2.41a1 Mozilla/5.0 (Windows NT 6.1; Win64; x64;
   rv:44.0 from akalla download area)  Gecko/20100101  Firefox/ 44.0  Build 20150926114543, 
   (Classic Theme) on German WIN7 64bit - New button design
b2) Still worked fine with en-US SeaMonkey 2.40 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) 
   from official download page,  Gecko/20100101  Firefox/ 43.0  Build 20150908212008, (Default
   Classic Theme) on German WIN7 64bit - Old simple button design

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1315924-typofix.patch

d'oh :)

[Approval Request Comment]
Regression caused by (bug #): 531285
User impact if declined: map button for private addresses not working.
Testing completed (on m-c, etc.): c-b
Risk to taking this patch (and alternatives if risky): non already broken.
String changes made by this patch: --

Asking for approval for all current trees and next esr.

Comment 9

[Ian Neal]

Comment on attachment 8906640 [details] [diff] [review]
1315924-typofix.patch

LGTM r/a=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bb96ca92a5c
Fix usage of wrong variable and invalid declaration for map button checking. r=IanN

Comment 11

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/a494d435a6eef7723e4cc9819c9b17bd4dff54ad
https://hg.mozilla.org/releases/comm-release/rev/41a888d5ecdb91e1f56c9f16f13f5ae9c346f6af
https://hg.mozilla.org/releases/comm-esr52/rev/b430f5e36eed980ec6baa43038849dda09ea6685

Fix will be in 2.49.2. Minor problem and I don't want to change the csets for the 2.49.1 relbranch again.