Still needs to be tested: ------------------------- b) Version of appearance? c) Linux, MAC? d) What new functions will button have?
Steps how to reproduce with official DE SeaMonkey 2.49a1 (NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 Build 20161107002359 (Default Classic Theme) on German WIN7 64bit: 1. Launch SeaMonkey with browser → menu ˋWindow → Address Bookˊ » Address Book appears 2. In Address Books Pane select an Address book 3. Select (click) a contact entry with a complete address (streeet, town, ... ) » Details pane below contacts lists shows a [Get Map] Bug: Button is greyed out and inactive a) Problem might be related to a new feature? in earlier SM versions there was a simple button, now we hafe a complex button with additional ▼ Arrow Down, probably for alternative functions. e) Safe Mode without addons does not heal the problem.
@Stefan: Can you confirm my problem
Bug 1310442 - Make labels of cmd_properties action-oriented and context-sensitive, e.g. "Edit Contact", "Edit List", etc. (consistent with improved dialogue titles from bug 1312262). https://hg.mozilla.org/comm-central/rev/71581aa20801 only pushed strings for mail/ but not suite/. Confirming per code review.
Bug 1310442 landed on 11/12 whereas the issue here was filed 11/08 already, makes me thinking that it's not quite the source for that specific regression. But anyway, we'll have to fix the suite/ strings, so maybe let's open a new bug for that and see to which extent it fixes the problem in this bug.
I did some tests with newly created user profile and imported addresses: b1) Already reproducible withGerman SeaMonkey 2.41a1 Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0 from akalla download area) Gecko/20100101 Firefox/ 44.0 Build 20150926114543, (Classic Theme) on German WIN7 64bit - New button design b2) Still worked fine with en-US SeaMonkey 2.40 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) from official download page, Gecko/20100101 Firefox/ 43.0 Build 20150908212008, (Default Classic Theme) on German WIN7 64bit - Old simple button design
Version: SeaMonkey 2.49 Branch → SeaMonkey 2.41 Branch
d'oh :) [Approval Request Comment] Regression caused by (bug #): 531285 User impact if declined: map button for private addresses not working. Testing completed (on m-c, etc.): c-b Risk to taking this patch (and alternatives if risky): non already broken. String changes made by this patch: -- Asking for approval for all current trees and next esr.
Comment on attachment 8906640 [details] [diff] [review] 1315924-typofix.patch LGTM r/a=me
Attachment #8906640 - Flags: review?(iann_bugzilla)
Attachment #8906640 - Flags: review+
Attachment #8906640 - Flags: approval-comm-release?
Attachment #8906640 - Flags: approval-comm-release+
Attachment #8906640 - Flags: approval-comm-esr52?
Attachment #8906640 - Flags: approval-comm-esr52+
Attachment #8906640 - Flags: approval-comm-beta?
Attachment #8906640 - Flags: approval-comm-beta+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/1bb96ca92a5c Fix usage of wrong variable and invalid declaration for map button checking. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/comm-beta/rev/a494d435a6eef7723e4cc9819c9b17bd4dff54ad https://hg.mozilla.org/releases/comm-release/rev/41a888d5ecdb91e1f56c9f16f13f5ae9c346f6af https://hg.mozilla.org/releases/comm-esr52/rev/b430f5e36eed980ec6baa43038849dda09ea6685 Fix will be in 2.49.2. Minor problem and I don't want to change the csets for the 2.49.1 relbranch again.
You need to log in before you can comment on or make changes to this bug.