Closed Bug 1315938 Opened 5 years ago Closed 5 years ago
Crash in java
.lang .Null Pointer Exception: Attempt to invoke virtual method ''boolean org .mozilla .gecko .Tab .is Private()'' on a null object reference at org .mozilla .gecko .home .Two Line Page Row .update Displayed Url(Two Line Page Row .java)
58 bytes, text/x-review-board-request
This bug was filed from the Socorro interface and is report bp-ce33a3a6-c248-4e4a-8f5c-3be1e2161107. ============================================================= This is number 10 on Aurora, and is likely to be a simple fix.
I've fiddled with TopSites a lot in the past, so I am probably a good candidate for looking into this.
Assignee: nobody → ahunt
Priority: -- → P1
Comment on attachment 8808590 [details] Bug 1315938 - Don't crash if tabs aren't initialised yet https://reviewboard.mozilla.org/r/91396/#review91636
Attachment #8808590 - Flags: review?(s.kaspari) → review+
Let's uplift this to 51.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bc22ca7ff05b Don't crash if tabs aren't initialised yet r=sebastian
Comment on attachment 8808590 [details] Bug 1315938 - Don't crash if tabs aren't initialised yet Approval Request Comment [Feature/regressing bug #]: Unknown - this bug seems to have always been present, but is only triggered in certain scenarios. [User impact if declined]: Startup crash if gecko is slow to load, or doesn't load. [Describe test coverage new/current, TreeHerder]: none (patch has been stabilised on nightly, no obvious issues visible). [Risks and why]: low risk - add null-check for a call that is specified to return null in certain scenarios. [String/UUID change made/needed]: none. This crash is currently 20th on Nightly, 15th on Aurora. It seemed to spike with the recent library loading issues (which would prevent gecko from being started before topsites is shown), however this is a beneficial fix in general. Without this patch we have a race condition between topsites being shown, and gecko loading, with a crash when topsites are shown first.
Attachment #8808590 - Flags: approval-mozilla-aurora?
Comment on attachment 8808590 [details] Bug 1315938 - Don't crash if tabs aren't initialised yet Fix a crash. Aurora51+.
Attachment #8808590 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.