Closed Bug 1315974 Opened 3 years ago Closed 3 years ago

Allow constructing widget layer managers that are not ClientLayerManagers without blowing up

Categories

(Core :: Graphics: WebRender, defect, P3)

52 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

The layer manager in the client process might be a WebRenderLayerManager, so we shouldn't assume it's always a ClientLayerManager.
As in, find all the places that use AsClientLayerManager() and see what the right thing to do is?
Priority: -- → P3
Whiteboard: [gfx-noted]
We probably don't need to track for 52?
(In reply to Milan Sreckovic [:milan] from comment #1)
> As in, find all the places that use AsClientLayerManager() and see what the
> right thing to do is?

What I really wanted to do was land the bits of my e10s+WR patches where I modified TabChild/nsBaseWidget to accomodate the WebRenderLayerManager. Updating bug summary to be a bit more precise.

We'll have to deal with the places that use AsClientLayerManager() eventually, but I don't want to do that as part of this bug. For now as long as it doesn't assume AsClientLayerManager() returns non-null on critical code paths I'm happy.
Summary: Try not to assume a content process' layer manager is always a ClientLayerManager → Allow constructing widget layer managers that are not ClientLayerManagers without blowing up
Comment on attachment 8808672 [details]
Bug 1315974 - When creating the widget layer manager, don't assume it will always be a ClientLayerManager.

https://reviewboard.mozilla.org/r/91440/#review91352
Attachment #8808672 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8808671 [details]
Bug 1315974 - Have the CompositorBridgeChild take a LayerManager instead of a ClientLayerManager.

https://reviewboard.mozilla.org/r/91438/#review91368
Attachment #8808671 - Flags: review?(dvander) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b6533d17d4c
Have the CompositorBridgeChild take a LayerManager instead of a ClientLayerManager. r=dvander
https://hg.mozilla.org/integration/autoland/rev/6864810d4390
When creating the widget layer manager, don't assume it will always be a ClientLayerManager. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/8b6533d17d4c
https://hg.mozilla.org/mozilla-central/rev/6864810d4390
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.