1316004 - [findbugs] [NP] Possible null pointer dereference of dispatcher in org.mozilla.gecko.javaaddons.JavaAddonManagerV1.handleMessage(String, NativeJSObject, EventCallback)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Possible null pointer dereference of dispatcher in org.mozilla.gecko.javaaddons.JavaAddonManagerV1.handleMessage(String, NativeJSObject, EventCallback)

"There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs."

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 2

[swaroop.rao]

Attachment: Bug 1316004 - Fixed by putting the offending statement in an else block;

Review commit: https://reviewboard.mozilla.org/r/92482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92482/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8810008 [details]
Bug 1316004 - Fixed by putting the offending statement in an else block;

https://reviewboard.mozilla.org/r/92482/#review92944

LGTM.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=029512ab7300

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc1cb5366882
Fixed by putting the offending statement in an else block; r=sebastian

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc1cb5366882

Comment 7

[areya]

https://hg.mozilla.org/mozilla-central/rev/fc1cb5366882