Closed Bug 1316004 Opened 3 years ago Closed 3 years ago

[findbugs] [NP] Possible null pointer dereference of dispatcher in org.mozilla.gecko.javaaddons.JavaAddonManagerV1.handleMessage(String, NativeJSObject, EventCallback)

Categories

(Firefox for Android :: General, defect, P3)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: sebastian, Assigned: swaroop.rao, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

Possible null pointer dereference of dispatcher in org.mozilla.gecko.javaaddons.JavaAddonManagerV1.handleMessage(String, NativeJSObject, EventCallback)

"There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs."
To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Comment on attachment 8810008 [details]
Bug 1316004 - Fixed by putting the offending statement in an else block;

https://reviewboard.mozilla.org/r/92482/#review92944

LGTM.
Attachment #8810008 - Flags: review?(s.kaspari) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=029512ab7300
Assignee: nobody → swaroop.rao
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc1cb5366882
Fixed by putting the offending statement in an else block; r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc1cb5366882
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.