Closed Bug 1316114 Opened 7 years ago Closed 7 years ago

dom/base/test/test_bug475156.html fails to run twice in the same browser session

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1316114 - reset sjs file at the end of the test case.
58 bytes, text/x-review-board-request
jmaher
: review+
Details 
this fails:
./mach mochitest dom/base/test/test_bug475156.html --repeat 1

our tests shouldn't be that fragile!
Assignee: nobody → jmaher
Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

https://reviewboard.mozilla.org/r/91530/#review91632

::: dom/base/test/test_bug475156.html:264
(Diff revision 1)
>    },
> +
> +  {
> +      init: function (xhr) {
> +          xhr.open("GET", path + "bug475156.sjs");
> +          xhr.setRequestHeader("If-Match", "a1");

I'm not author of this test.  if this helps, then I don't understand how.  but if it does, land it.

please fix the indent to be 2 spaces
Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

how much I don't like rb....
Attachment #8808785 - Flags: review?(honzab.moz) → review+
what happens is the internal state in the .sjs file is set at a3, so when we run again, it is cached and gets a3 instead of a fresh value of a1.
Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

sorry about that :(  I obviously don't know how to use mozreview and will switch to a splinter patch with the whitespace changes.
Attachment #8808785 - Flags: review?(honzab.moz)
Attachment #8808785 - Attachment is obsolete: true
Attachment #8809163 - Flags: review?(honzab.moz) → review+
Comment on attachment 8809163 [details]
Bug 1316114 - reset sjs file at the end of the test case.

https://reviewboard.mozilla.org/r/91800/#review91726

reviewed in the previous attempt to push this.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c62fafdf682
reset sjs file at the end of the test case. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/5c62fafdf682
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.