1316114 - dom/base/test/test_bug475156.html fails to run twice in the same browser session

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this fails:
./mach mochitest dom/base/test/test_bug475156.html --repeat 1

our tests shouldn't be that fragile!

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1316114 - reset sjs file at the end of the test case.

Review commit: https://reviewboard.mozilla.org/r/91530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91530/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e59ca72ae9ecdc3dd402096110c7ddda6acb3f48

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

https://reviewboard.mozilla.org/r/91530/#review91632

::: dom/base/test/test_bug475156.html:264
(Diff revision 1)
>    },
> +
> +  {
> +      init: function (xhr) {
> +          xhr.open("GET", path + "bug475156.sjs");
> +          xhr.setRequestHeader("If-Match", "a1");

I'm not author of this test.  if this helps, then I don't understand how.  but if it does, land it.

please fix the indent to be 2 spaces

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

how much I don't like rb....

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

what happens is the internal state in the .sjs file is set at a3, so when we run again, it is cached and gets a3 instead of a fresh value of a1.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91530/diff/1-2/

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8808785 [details]
Bug 1316114 - reset sjs file at the end of the test case.

sorry about that :(  I obviously don't know how to use mozreview and will switch to a splinter patch with the whitespace changes.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1316114 - reset sjs file at the end of the test case.

Review commit: https://reviewboard.mozilla.org/r/91800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91800/

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8809163 [details]
Bug 1316114 - reset sjs file at the end of the test case.

https://reviewboard.mozilla.org/r/91800/#review91726

reviewed in the previous attempt to push this.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c62fafdf682
reset sjs file at the end of the test case. r=jmaher

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c62fafdf682