Closed
Bug 1316116
Opened 8 years ago
Closed 8 years ago
clang-cl build error in TestNamedPipeService.cpp
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.33 KB,
patch
|
bagder
:
review+
|
Details | Diff | Splinter Review |
38:02.69 d:/build/msys/s/central/netwerk/test/TestNamedPipeService.cpp(306,28): error(clang): cannot initialize a parameter of type 'void *' with an lvalue of type 'const char [12]'
38:02.69 if (writeObserver->Write(TEST_STR, sizeof(TEST_STR)) != sizeof(TEST_STR)) {
38:02.69 ^~~~~~~~
This can be fixed by making the first parameter |const void*|.Assignee: nobody → dmajor
Attachment #8808789 -
Flags: review?(daniel)
|
||
Updated•8 years ago
|
Attachment #8808789 -
Flags: review?(daniel) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f8636cfef924 Fix the clang-cl build in TestNamedPipeService.cpp. r=bagder
|
||
Updated•8 years ago
|
Whiteboard: [necko-active]
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f8636cfef924
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•