clang-cl build error in TestNamedPipeService.cpp

RESOLVED FIXED in Firefox 52

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
38:02.69 d:/build/msys/s/central/netwerk/test/TestNamedPipeService.cpp(306,28):  error(clang): cannot initialize a parameter of type 'void *' with an lvalue of type 'const char [12]'
38:02.69   if (writeObserver->Write(TEST_STR, sizeof(TEST_STR)) != sizeof(TEST_STR)) {
38:02.69                            ^~~~~~~~

This can be fixed by making the first parameter |const void*|.
(Assignee)

Comment 1

2 years ago
Created attachment 8808789 [details] [diff] [review]
testnamedpipeservice
Assignee: nobody → dmajor
Attachment #8808789 - Flags: review?(daniel)
Attachment #8808789 - Flags: review?(daniel) → review+

Comment 2

2 years ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8636cfef924
Fix the clang-cl build in TestNamedPipeService.cpp. r=bagder
Whiteboard: [necko-active]

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8636cfef924
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.