Closed
Bug 1316117
Opened 8 years ago
Closed 7 years ago
Remove "support" for try: -a by defaulting -b to none in buildbot
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: billm, Assigned: philor)
References
Details
(Keywords: trychooser)
Attachments
(1 file)
8.50 KB,
patch
|
catlee
:
review+
philor
:
checked-in+
|
Details | Diff | Splinter Review |
I had assumed that "try: -a" meant the same thing as "try: -b do -p all -u all -t <something>". However, it seems that it doesn't actually do anything for TaskCluster. I'm basing this on https://bugzilla.mozilla.org/show_bug.cgi?id=1272159#c8 and on the fact that I was backed out for Linux64 build bustage despite running try -a. So at this point it seems that "try: -a" just runs a random collection of jobs. I think it should be removed so that other people don't get backed out for this reason. If you use "try: -a", you should get an error telling you to use a different syntax.
Assignee | ||
Comment 1•8 years ago
|
||
See bug 1303663 comment 1 - actual support for -a was removed in 2011, and since then it has been just the defaults for each of -b/-p/-u/-t, the same as "try: garbage". Then, incomprehensibly making different incomprehensible decisions than buildbot's incomprehensible decisions, taskcluster chose to have defaults for -p/-u/-t, but no default for -b. And an error message is not an option, the only option is to get nothing at all run, ask why, be told that it was a result of using something that hasn't been supported since 2011.
Blocks: 1303663
Keywords: trychooser
Summary: Remove support for try: -a → Remove "support" for try: -a by defaulting -b to none in buildbot
Assignee | ||
Comment 2•8 years ago
|
||
Chances are this probably works.
Updated•8 years ago
|
Attachment #8816738 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8816738 [details] [diff] [review] Fix https://hg.mozilla.org/build/buildbotcustom/rev/29c538e1ab2a284956415f9956de7d450995ff45
Attachment #8816738 -
Flags: checked-in+
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•