Closed Bug 1316127 Opened 7 years ago Closed 7 years ago

Add more corner cases to the TestEscapeURL gtest

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: RyanVM, Unassigned)

Details

Attachments

(1 file)

add tests for edge cases for nsUnescapeCount
1.42 KB, patch
erahm
: review+
Details | Diff | Splinter Review 
Came up in a recent conversation with Nathan, wanted to get it filed before forgetting.
There are no tests for this piece of code otherwise, and it'd be good to
have cases for non-escape sequences of various flavors.
Attachment #8808801 - Flags: review?(erahm)
Comment on attachment 8808801 [details] [diff] [review]
add tests for edge cases for nsUnescapeCount

Review of attachment 8808801 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable. On a side note: nsUnescapeCount count could really use some comments.
Attachment #8808801 - Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dff5bc50c120
add tests for edge cases for nsUnescapeCount; r=erahm
https://hg.mozilla.org/mozilla-central/rev/dff5bc50c120
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.