Closed
Bug 1316127
Opened 9 years ago
Closed 9 years ago
Add more corner cases to the TestEscapeURL gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: RyanVM, Unassigned)
Details
Attachments
(1 file)
|
1.42 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
Came up in a recent conversation with Nathan, wanted to get it filed before forgetting.
|
||
Comment 1•9 years ago
|
||
There are no tests for this piece of code otherwise, and it'd be good to
have cases for non-escape sequences of various flavors.
Attachment #8808801 -
Flags: review?(erahm)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8808801 [details] [diff] [review]
add tests for edge cases for nsUnescapeCount
Review of attachment 8808801 [details] [diff] [review]:
-----------------------------------------------------------------
Seems reasonable. On a side note: nsUnescapeCount count could really use some comments.
Attachment #8808801 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dff5bc50c120
add tests for edge cases for nsUnescapeCount; r=erahm
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•