Closed
Bug 1316135
Opened 8 years ago
Closed 8 years ago
Convert eslint warnings to errors under /accessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file)
There are 30 warnings related to no-shadow and no-return-assign under /accessible. Other parts of our code-base enforce these as errors.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8809267 [details]
Bug 1316135 - Convert eslint warnings to errors under /accessible.
https://reviewboard.mozilla.org/r/91854/#review91900
Looks good. Definitely shoul be keeping away from warnings if we can.
Attachment #8809267 -
Flags: review?(standard8) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/496f18cd01fe
Convert eslint warnings to errors under /accessible. r=standard8
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•