1316164 - NativeGetElement is not defined.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

https://dxr.mozilla.org/mozilla-central/rev/f13e90d496cf1bc6dfc4fd398da33e4afe785bde/js/src/vm/NativeObject.h#1409-1411

> extern bool
> NativeGetElement(JSContext* cx, HandleNativeObject obj, HandleValue receiver, uint32_t index,
>                  MutableHandleValue vp);

It has no definition.

and the following inline also doesn't work.

https://dxr.mozilla.org/mozilla-central/rev/f13e90d496cf1bc6dfc4fd398da33e4afe785bde/js/src/vm/NativeObject.h#1420-1425
> inline bool
> NativeGetElement(JSContext* cx, HandleNativeObject obj, uint32_t index, MutableHandleValue vp)
> {
>     RootedValue receiver(cx, ObjectValue(*obj));
>     return NativeGetElement(cx, obj, receiver, index, vp);
> }

they should be removed.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove unused/undefined NativeGetElement declaration.

5-ary NativeGetElement is not defined but there's only declaration.
4-ary NativeGetElement is defined but it calls 5-ary one.

Removed both of them.

Comment 2

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb60b1702ed9aa9dec06a0e6b7395aa373e88589
Bug 1316164 - Remove unused/undefined NativeGetElement declaration. r=evilpie

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb60b1702ed9