Closed Bug 1316164 Opened 3 years ago Closed 3 years ago

NativeGetElement is not defined.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

https://dxr.mozilla.org/mozilla-central/rev/f13e90d496cf1bc6dfc4fd398da33e4afe785bde/js/src/vm/NativeObject.h#1409-1411

> extern bool
> NativeGetElement(JSContext* cx, HandleNativeObject obj, HandleValue receiver, uint32_t index,
>                  MutableHandleValue vp);

It has no definition.

and the following inline also doesn't work.

https://dxr.mozilla.org/mozilla-central/rev/f13e90d496cf1bc6dfc4fd398da33e4afe785bde/js/src/vm/NativeObject.h#1420-1425
> inline bool
> NativeGetElement(JSContext* cx, HandleNativeObject obj, uint32_t index, MutableHandleValue vp)
> {
>     RootedValue receiver(cx, ObjectValue(*obj));
>     return NativeGetElement(cx, obj, receiver, index, vp);
> }

they should be removed.
5-ary NativeGetElement is not defined but there's only declaration.
4-ary NativeGetElement is defined but it calls 5-ary one.

Removed both of them.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #8808977 - Flags: review?(evilpies)
Attachment #8808977 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb60b1702ed9aa9dec06a0e6b7395aa373e88589
Bug 1316164 - Remove unused/undefined NativeGetElement declaration. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/eb60b1702ed9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.