1316168 - clang-cl build error in nsExceptionHandler.cpp

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(Away)]

4:07.44 d:/build/msys/s/central/toolkit/crashreporter/nsExceptionHandler.cpp(526,14):  error(clang): call to constructor of 'xpstring' (aka 'basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> >') is ambiguous
 4:07.44   return new xpstring(path.get(), path.Length());
 4:07.44              ^        ~~~~~~~~~~~~~~~~~~~~~~~~~

nsExceptionHandler.cpp is full of char16_t/wchar_t mismatch (search for "reinterpret_cast<wchar_t*>"), so this is nothing new.

The tricky thing about this one, though, is that path.get() is a char16ptr_t, so we have to do a yucky C-cast to trigger its operator wchar_t*().

Comment 1

[(Away)]

Attachment: C-style cast

Comment 2

[(Away)]

Actually I guess static_cast would work too...

Comment 3

[(Away)]

Attachment: static_cast

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8808827 [details] [diff] [review]
static_cast

Review of attachment 8808827 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for testing the C++ cast version!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/986861e6c5ce
Fix the clang-cl build in nsExceptionHandler.cpp. r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/986861e6c5ce