Closed
Bug 1316194
Opened 8 years ago
Closed 8 years ago
Remove unused XPCOM test TestINIParser
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestINIParser.cpp to a gtest and move to xpcom/tests/gtest/. Currently the test requires you to pass in a file path, we'll have to modify that a bit. Maybe just write out a temp file and embed an ini in the test or update the parser to handle a string instead.
|
Assignee | |
Comment 1•8 years ago
|
||
This is really just an ad hoc test for INI files, there's nothing really being tested. Lets just remove it, we can file a bug to add a real test if we're particularly concerned.
|
|
Assignee | |
Updated•8 years ago
|
Summary: Convert XPCOM test TestINIParser to a gtest → Remove unused XPCOM test TestINIParser
|
|
Assignee | |
Comment 2•8 years ago
|
||
MozReview-Commit-ID: 2gQgR6V3kee
Attachment #8809122 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Attachment #8809122 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/375bb353c101e51e74388cc4cce22164928563f5 Bug 1316194 - Remove unused XPCOM test TestINIParser. r=bsmedberg
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/375bb353c101
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•