Closed Bug 1316238 Opened 4 years ago Closed 4 years ago

Intermittent devtools/client/inspector/test/browser_inspector_search-05.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure)

Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P2
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
This test only fails on windows 32 VM debug e10s. 
What is strange is that the average time for this test on this platform jumped from 20 seconds to 45 seconds since last week while the test itself did not change. Other tests in the same suite did not show any slowdown. And this test (browser_inspector_search-05.js) did not slow down on any other platform ... 

Doing a few more try runs before going for a requestLongerTimeout.
(In reply to Julian Descottes [:jdescottes] from comment #6)
> Doing a few more try runs before going for a requestLongerTimeout.

Instant doubling of runtime feels like something that warrants more exploration before wallpapering over it. FWIW, bug 1308257 landed shortly before this started to spike. Maybe that's related?
this is now the #1 intermittent orange (that isn't fixed)- :jdescottes, have you had any luck with try pushes?  need any help?
(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
> (In reply to Julian Descottes [:jdescottes] from comment #6)
> > Doing a few more try runs before going for a requestLongerTimeout.
> 
> Instant doubling of runtime feels like something that warrants more
> exploration before wallpapering over it. FWIW, bug 1308257 landed shortly
> before this started to spike. Maybe that's related?

Thanks for the heads up. I triggered a try run with and without this bug, and both run the test in under 20 seconds. My other tests have not provided more information yet.
I will keep digging but this is really a time consuming process and in the meantime I think we should requestLongerTimeout for this test.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca6679299778
request longer timeout for browser_inspector_search-05.js;r=test-only
https://hg.mozilla.org/mozilla-central/rev/ca6679299778
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.