Closed
Bug 1316245
Opened 6 years ago
Closed 6 years ago
Pass WebGL2 conformance conformance2/misc/uninitialized-test-2.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: ethlin, Assigned: ethlin)
References
()
Details
Attachments
(1 file, 3 obsolete files)
2.34 KB,
patch
|
jgilbert
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. ...
Assignee | ||
Comment 1•6 years ago
|
||
We should bind texture first before doing TexSubImage.
Attachment #8808919 -
Flags: review?(jgilbert)
Comment 2•6 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #1) > Created attachment 8808919 [details] [diff] [review] > bind texture > > We should bind texture first before doing TexSubImage. Wow, oops.
Comment 3•6 years ago
|
||
Comment on attachment 8808919 [details] [diff] [review] bind texture Review of attachment 8808919 [details] [diff] [review]: ----------------------------------------------------------------- It looks like the same issue applies to the compressed texture one, so move this scope object further up in the function please.
Attachment #8808919 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #3) > Comment on attachment 8808919 [details] [diff] [review] > bind texture > > Review of attachment 8808919 [details] [diff] [review]: > ----------------------------------------------------------------- > > It looks like the same issue applies to the compressed texture one, so move > this scope object further up in the function please. Okay.
Assignee | ||
Comment 5•6 years ago
|
||
I move the bind function up before the compression check.
Attachment #8809295 -
Flags: review?(jgilbert)
Assignee | ||
Updated•6 years ago
|
Attachment #8808919 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #8809295 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 6•6 years ago
|
||
Fix try server failures.
Attachment #8809295 -
Attachment is obsolete: true
Assignee | ||
Comment 7•6 years ago
|
||
Sorry, this is the correct one.
Attachment #8812086 -
Attachment is obsolete: true
Assignee | ||
Comment 8•6 years ago
|
||
try server result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc30b14f180ac54119004d02102458026dd11230
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/339c60ab68e4 In ZeroTextureData, bind texture before cleaning it. r=jgilbert
Keywords: checkin-needed
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/339c60ab68e4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Comment on attachment 8812091 [details] [diff] [review] bind texture (carry r+: jgilbert) Approval Request Comment [Feature/Bug causing the regression]: webgl2 [User impact if declined]: [Is this code covered by automated tests?]: [Has the fix been verified in Nightly?]: [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: [Is the change risky?]: [Why is the change risky/not risky?]: [String changes made/needed]:
Attachment #8812091 -
Flags: review+
Attachment #8812091 -
Flags: approval-mozilla-beta?
Attachment #8812091 -
Flags: approval-mozilla-aurora?
Comment 12•6 years ago
|
||
Comment on attachment 8812091 [details] [diff] [review] bind texture (carry r+: jgilbert) WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.
Attachment #8812091 -
Flags: approval-mozilla-beta?
Attachment #8812091 -
Flags: approval-mozilla-beta+
Attachment #8812091 -
Flags: approval-mozilla-aurora?
Attachment #8812091 -
Flags: approval-mozilla-aurora+
Comment 13•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ec721f96b035
Comment 14•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/49f9cf06deef
You need to log in
before you can comment on or make changes to this bug.
Description
•