1316245 - Pass WebGL2 conformance conformance2/misc/uninitialized-test-2.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
failed: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061.
...

Comment 1

[Ethan Lin[:ethlin]]

Attachment: bind texture

We should bind texture first before doing TexSubImage.

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Ethan Lin[:ethlin] from comment #1)
> Created attachment 8808919 [details] [diff] [review]
> bind texture
> 
> We should bind texture first before doing TexSubImage.

Wow, oops.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8808919 [details] [diff] [review]
bind texture

Review of attachment 8808919 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like the same issue applies to the compressed texture one, so move this scope object further up in the function please.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Comment on attachment 8808919 [details] [diff] [review]
> bind texture
> 
> Review of attachment 8808919 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It looks like the same issue applies to the compressed texture one, so move
> this scope object further up in the function please.

Okay.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: bind texture

I move the bind function up before the compression check.

Comment 6

[Ethan Lin[:ethlin]]

Attachment: bind texture (carry r+: jgilbert)

Fix try server failures.

Comment 7

[Ethan Lin[:ethlin]]

Attachment: bind texture (carry r+: jgilbert)

Sorry, this is the correct one.

Comment 8

[Ethan Lin[:ethlin]]

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc30b14f180ac54119004d02102458026dd11230

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/339c60ab68e4
In ZeroTextureData, bind texture before cleaning it. r=jgilbert

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/339c60ab68e4

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8812091 [details] [diff] [review]
bind texture (carry r+: jgilbert)

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8812091 [details] [diff] [review]
bind texture (carry r+: jgilbert)

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ec721f96b035

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/49f9cf06deef