Gyp builds violate ODR

RESOLVED FIXED in 3.30

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: franziskus, Assigned: ttaubert)

Tracking

trunk
3.30
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Building gyp with asan shows that there are a couple odr violations. We should fix them so that we can remove ASAN_OPTIONS=detect_odr_violation=0.
What's broken here?
You can reproduce errors like the one below when running for example ssl_gtest after building with asan (./build.sh --asan)

> ==18211==ERROR: AddressSanitizer: odr-violation (0x000000d43600):
>   [1] size=144 'SSL_ImplementedCiphers' ../../lib/ssl/sslenum.c:57:16
>   [2] size=144 'SSL_ImplementedCiphers' ../../lib/ssl/sslenum.c:57:16
> These globals were registered at these points:
>   [1]:
>     #0 0x484d60 in __asan_register_globals.part.10 (/home/franziskus/Code/dist/Debug/bin/ssl_gtest+0x484d60)
>     #1 0x92bb3b in asan.module_ctor (/home/franziskus/Code/dist/Debug/bin/ssl_gtest+0x92bb3b)
> 
>   [2]:
>     #0 0x484d60 in __asan_register_globals.part.10 (/home/franziskus/Code/dist/Debug/bin/ssl_gtest+0x484d60)
>     #1 0x7fc5e5b9936b in asan.module_ctor (/home/franziskus/Code/dist/Debug/lib/libssl3.so+0x10c36b)
> 
> ==18211==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
> SUMMARY: AddressSanitizer: odr-violation: global 'SSL_ImplementedCiphers' at ../../lib/ssl/sslenum.c:57:16
> ==18211==ABORTING
That's correct, but that doesn't solve the problem :(
Should be fixed by bug 1333361.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Depends on: 1333361
Bug 1333361 landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.30
You need to log in before you can comment on or make changes to this bug.