1316296 - font-inspector has a 20px gap at the bottom

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

- go to about:home
- open inspector
- select font tab
- reduce devtools height until you see a white gap at the bottom of the font inspector

ER: there should be no gap
AR: there is a gap

There is a 20px bottom padding defined at http://searchfox.org/mozilla-central/rev/008fdd93290c83325de6629a1ae48dc2afaed868/devtools/client/themes/fonts.css#9 

Before inspector.xul was migrated to html (Bug 1262443), this padding had no effect on the actual display, but it should probably be removed now.

Comment 1

[Sam Clusker]

Hi Julian,

May I be assigned to this bug please? Seems like a nice one to start.

Thanks,
Sam

Comment 2

[Julian Descottes [:jdescottes]]

Thanks Sam, assigning the bug to you now!

If you're new to bugzilla and/or contributing to firefox, here are some pointers to get started:
- go through our contribution guide: https://developer.mozilla.org/en-US/docs/Tools/Contributing
- to investigate the issue, I recommend using the "Browser Toolbox", as described here: https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox

As I mentioned in comment #0, removing the padding should probably be good enough here. If you run into any issue, either comment here or ping me on IRC.

By the way, if you want to make sure someone sees your question in Bugzilla, you can ping the person using the "Need more information from" form below.

Comment 3

[Iulian Radu]

Attachment: Remove gap at the bottom of font-inspector.

Hello,

I noticed that there hasn't been any recent activity for this bug report and I went on and created a patch for it. Please let me know if the patch has the right format as it is the first one I do for Mozilla.

Comment 4

[Julian Descottes [:jdescottes]]

Iulian: Thanks! No activity for a month, I think it's fair to reassign it to you.

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8819090 [details] [diff] [review]
Remove gap at the bottom of font-inspector.

Review of attachment 8819090 [details] [diff] [review]:
-----------------------------------------------------------------

Great patch Iulian, thanks! 

The formatting and changeset summary are both fine (we don't usually include the priority in the bug summary, but that's not a big deal).
I just pushed your changeset to our continuous integration platform (try). You can follow the test results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a852c0238e2be938b5d980a63bed64906bf7d66

This will run the devtools test suite on various platforms, to make sure the changeset doesn't introduce an unforeseen regression. Seems very unlikely given the nature of the bug, but better be safe than sorry. 

The tests will take a few hours to complete. If they are "green", we will add the checkin-needed keyword to the bug so that a sheriff can pick your patch and land it on an integration branch. After that your patch will "ride" the release train and will make its way to Firefox 53 which should become the release version of Firefox in April (https://wiki.mozilla.org/RapidRelease/Calendar).

Comment 6

[Julian Descottes [:jdescottes]]

Try is green, adding checkin-needed.

Thanks for your contribution Iulian!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4ddb0dd0520
Remove gap at the bottom of font-inspector. r=jdescottes

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a4ddb0dd0520

Comment 9

[Sajedul Islam]

I have reproduced this bug with Nightly  52.0a1 (2016-11-09) on Windows 8.1 , 64 Bit ! 

Build   ID    20161109030210
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

This bug's fix is Verified with latest Nightly !

Build   ID    20161220030215
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20161221]

Comment 10

[Sylvestre Ledru [:Sylvestre]]

I guess we want this to ride the train.