Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
The assertion I added to DrawTargetSkia::CreateSimilarDrawTarget in bug 1309272, part 2 fails with printing via Skia PDF (bug 1309272). I'd like to relax that for now.
Assignee

Comment 1

3 years ago
Posted patch patchSplinter Review
Attachment #8809010 - Flags: review?(lsalzman)
Assignee

Updated

3 years ago
Depends on: 1316322
Attachment #8809010 - Flags: review?(lsalzman) → review+

Comment 2

3 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d68ce32250
Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning. r=lsalzman

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b3d68ce32250
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Comment 4

3 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b62b77eb236
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
Assignee

Comment 5

3 years ago
The original patch's logic was inverted. I took the liberty of landing the fix r=lsalzman.
I had to back this out (along with your other bugs pushed today) for windows vm debug failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39173435&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/91b1add28ef64ca507a1c1c14db2031ae37c992b
Flags: needinfo?(jwatt)

Comment 7

3 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0912331c9f31
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
Assignee

Comment 8

3 years ago
(In reply to Wes Kocher (:KWierso) from comment #6)
> I had to back this out (along with your other bugs pushed today) for windows
> vm debug failures

It doesn't look like the patch for this bug was related to those failures.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.