Closed Bug 1316299 Opened 4 years ago Closed 4 years ago

Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

The assertion I added to DrawTargetSkia::CreateSimilarDrawTarget in bug 1309272, part 2 fails with printing via Skia PDF (bug 1309272). I'd like to relax that for now.
Attached patch patchSplinter Review
Attachment #8809010 - Flags: review?(lsalzman)
Depends on: 1316322
Attachment #8809010 - Flags: review?(lsalzman) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d68ce32250
Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/b3d68ce32250
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b62b77eb236
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
The original patch's logic was inverted. I took the liberty of landing the fix r=lsalzman.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0912331c9f31
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
(In reply to Wes Kocher (:KWierso) from comment #6)
> I had to back this out (along with your other bugs pushed today) for windows
> vm debug failures

It doesn't look like the patch for this bug was related to those failures.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.