1316299 - Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

The assertion I added to DrawTargetSkia::CreateSimilarDrawTarget in bug 1309272, part 2 fails with printing via Skia PDF (bug 1309272). I'd like to relax that for now.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d68ce32250
Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning. r=lsalzman

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3d68ce32250

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b62b77eb236
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman

Comment 5

[Jonathan Watt [:jwatt]]

The original patch's logic was inverted. I took the liberty of landing the fix r=lsalzman.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out (along with your other bugs pushed today) for windows vm debug failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39173435&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/91b1add28ef64ca507a1c1c14db2031ae37c992b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0912331c9f31
Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman

Comment 8

[Jonathan Watt [:jwatt]]

(In reply to Wes Kocher (:KWierso) from comment #6)
> I had to back this out (along with your other bugs pushed today) for windows
> vm debug failures

It doesn't look like the patch for this bug was related to those failures.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0912331c9f31