Closed Bug 1316299 Opened 5 years ago Closed 5 years ago
Change assertion in Draw
Target Skia::Create Similar Draw Target to a warning
The assertion I added to DrawTargetSkia::CreateSimilarDrawTarget in bug 1309272, part 2 fails with printing via Skia PDF (bug 1309272). I'd like to relax that for now.
Attachment #8809010 - Flags: review?(lsalzman) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d68ce32250 Change assertion in DrawTargetSkia::CreateSimilarDrawTarget to a warning. r=lsalzman
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b62b77eb236 Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
The original patch's logic was inverted. I took the liberty of landing the fix r=lsalzman.
I had to back this out (along with your other bugs pushed today) for windows vm debug failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39173435&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/91b1add28ef64ca507a1c1c14db2031ae37c992b
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/0912331c9f31 Invert broken logic in DrawTargetSkia::CreateSimilarDrawTarget's warning. r=lsalzman
(In reply to Wes Kocher (:KWierso) from comment #6) > I had to back this out (along with your other bugs pushed today) for windows > vm debug failures It doesn't look like the patch for this bug was related to those failures.
You need to log in before you can comment on or make changes to this bug.