Do not show the login capture doorhanger during generic mochitests

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Password Manager
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The mochitest framework (plain, chrome, and browser) is used across the tree to test various web platform features as well as browser user interface.

When forms containing a password field are used in a mochitest, a side effect that is not obvious to the test writer is that the login capture doorhanger will be shown, and will remain displayed even during later tests.

Currently, this behavior is responsible for some intermittent failures in mochitests, because the doorhanger is closed only if a navigation happens after a certain timeout. We are now changing how the doorhanger works in bug 1282768, and this made some of the intermittent failures permanent.

Even if generally we keep the same configuration in tests and release because we want to test exactly what we ship, in this case I think it makes sense to disable the doorhanger unless we are specifically testing it.

This is the opposite of the current pattern for which a test that would cause the doorhanger to open would reset the preference. This makes sense because, if a generic mochitest inadvertently displays the doorhanger, the test would *not* fail, but it would cause a possibly intermittent failure in a different test. This means that a developer may easily miss that they have to explicitly reset the preference when adding a new test.
Comment hidden (mozreview-request)
Priority: -- → P1
Whiteboard: [fxprivacy]
Comment hidden (mozreview-request)
Comment on attachment 8808998 [details]
Bug 1316311 - Do not show the login capture doorhanger during generic mochitests.

https://reviewboard.mozilla.org/r/91692/#review92210
Attachment #8808998 - Flags: review?(MattN+bmo) → review+

Comment 5

2 years ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7efab71fda
Do not show the login capture doorhanger during generic mochitests. r=MattN

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b7efab71fda
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee: nobody → paolo.mozmail
You need to log in before you can comment on or make changes to this bug.