131633 - pressing tab key after typing # should complete current channel name

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Garth Wallace]

In mIRC, you can type # and hit tab to insert the name of the current channel.
It can be quite useful.

Comment 1

[James Ross]

I would also like to have all the channels for the current network to be
tab-completable, maybe even all the channel open on all the networks...

Comment 2

[James Ross]

Think I can do this.

Comment 3

[James Ross]

Attachment: diff -U 6 of /mozilla/extensions/irc/xul/content/static.js

Ok, first go - this patch should add the ability to tab complete any channel on
the network/server you're currently viewing, in adition to the nicknames in the
current channel.

Comment 4

[James Ross]

Taking properly - damn Bugzilla and it's odd options.

Comment 5

[Garth Wallace]

James: do you mean it'll tab-complete any channel you're joined to on a single
server? Because tab-completing any channel on the server would require a LIST
query, which would be an awful lot of overhead for one tab-completion.

Comment 6

[James Ross]

Ok, I'll just clear up what the patch does (I've been asked about this on IRC too).

The patch modifies the routine that generates the list of tab-completion
choices. What it does is include the list of known users (in the channel, or
network as appropriate) and the list of known channels on the network.

This means that, like the nickname-completion, you can only tab-complete
channels you have been in, though you don't need to still be in them. This list
is seperate for each server, and is (I think) reset when you connect to the server.

In short, the patch only uses the existing information in the ChatZilla object
model to build the tab-completion list - there is no network activity. HTH.

Comment 7

[Garth Wallace]

I see. I still have to ask, however, if it addresses the issue in this bug's
summary: can the user type # <tab> to get the channelname of the current channel
tab?

Comment 8

[James Ross]

Yes, the current channel will be one of the channels in the list. I thought it
would be nice (i.e. more consitent) if it had all the channels you were in on
the current server.

If you really only want the current channel tab-completable, or want anything
special (e.g. #c<tab> completes channels begining with c, but #<tab> always
fills in the current channel, even if there are other options) feel free to say.

Comment 9

[Garth Wallace]

> Yes, the current channel will be one of the channels in the list.

Yes, I figured as much.

> I thought it
> would be nice (i.e. more consitent) if it had all the channels you were in on
> the current server.

It would.

> If you really only want the current channel tab-completable,

I didn't mean to say that it should be *restricted* to that.

> or want
> anything special (e.g. #c<tab> completes channels begining with c, but #<tab>
> always fills in the current channel, even if there are other options) feel
> free to say.

#<tab> always completing the current channel even when there are other options
is the behavior this feature request was opened for. I think it's the
bare-minimum behavior, although being able to tab-complete other partly-typed
channels would be a convenient extra.

Comment 10

[James Ross]

Ok, I'll do an updated patch to make #<tab> complete to the current channel name
irrespective of the other options (though the others will still be there, and
will be used if you've got anything after the #).

Comment 11

[James Ross]

Attachment: diff -U 6 again, same file

Changes the code to explictly cope with #<tab> by completing to the current
channel name, if there is one. If not, works like a normal tab-complete.

Comment 12

[Garth Wallace]

Great! Thank you.

Comment 13

[Robert Ginda]

Attachment: edited patch

Thanks for the patch.  I edited it slightly and have included it in
0.8.12-pre8.  Have a look a this attachment for the edits, nothing too severe.

Comment 14

[Robert Ginda]

checked in