Closed
Bug 1316338
Opened 8 years ago
Closed 8 years ago
Make PrintTargetThebes set mHasActivePage as appropriate
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
945 bytes,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
PrintTargetThebes doesn't call through to the base class methods in most cases since it wraps a gfxSurface rather than a cairo_surface_t. PrintTargetThebes needs to set mHasActivePage as appropriate to avoid triggering assertions.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8809047 -
Flags: review?(lsalzman)
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7bd28df4ec Make PrintTargetThebes set mHasActivePage as appropriate. r=lsalzman
Comment 3•8 years ago
|
||
Comment on attachment 8809047 [details] [diff] [review] patch This is okay, but it might be cleaner to just call the methods on the superclass that already do that for you instead? i.e. PrintTarget::BeginPage(); and PrintTarget::EndPage()?
Attachment #8809047 -
Flags: review?(lsalzman) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Oops. Got a little over eager and failed to remove this from the bunch of patches I just batched up and landed. Sorry about that. However, this class will be going away soon, so I won't make the minor change you suggest unless you insist.
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef7bd28df4ec
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•