Make PrintTargetThebes set mHasActivePage as appropriate

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

PrintTargetThebes doesn't call through to the base class methods in most cases since it wraps a gfxSurface rather than a cairo_surface_t. PrintTargetThebes needs to set mHasActivePage as appropriate to avoid triggering assertions.
Blocks: 1280324
Posted patch patchSplinter Review
Attachment #8809047 - Flags: review?(lsalzman)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7bd28df4ec
Make PrintTargetThebes set mHasActivePage as appropriate. r=lsalzman
Comment on attachment 8809047 [details] [diff] [review]
patch

This is okay, but it might be cleaner to just call the methods on the superclass that already do that for you instead? i.e. PrintTarget::BeginPage(); and PrintTarget::EndPage()?
Attachment #8809047 - Flags: review?(lsalzman) → review+
Oops. Got a little over eager and failed to remove this from the bunch of patches I just batched up and landed. Sorry about that. However, this class will be going away soon, so I won't make the minor change you suggest unless you insist.
https://hg.mozilla.org/mozilla-central/rev/ef7bd28df4ec
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.