Closed Bug 1316338 Opened 5 years ago Closed 5 years ago
Target Thebes set m Has Active Page as appropriate
PrintTargetThebes doesn't call through to the base class methods in most cases since it wraps a gfxSurface rather than a cairo_surface_t. PrintTargetThebes needs to set mHasActivePage as appropriate to avoid triggering assertions.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7bd28df4ec Make PrintTargetThebes set mHasActivePage as appropriate. r=lsalzman
Comment on attachment 8809047 [details] [diff] [review] patch This is okay, but it might be cleaner to just call the methods on the superclass that already do that for you instead? i.e. PrintTarget::BeginPage(); and PrintTarget::EndPage()?
Attachment #8809047 - Flags: review?(lsalzman) → review+
Oops. Got a little over eager and failed to remove this from the bunch of patches I just batched up and landed. Sorry about that. However, this class will be going away soon, so I won't make the minor change you suggest unless you insist.
You need to log in before you can comment on or make changes to this bug.