Set HSTS priming request urgent-start class

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In HSTSPrimingListener::StartHSTSPriming.
Assignee: nobody → honzab.moz
Whiteboard: [necko-active]
(Assignee)

Comment 1

2 years ago
Created attachment 8842414 [details] [diff] [review]
v1

This makes the channel go out with a super-high priority and even unblocked by any parallelism limits so that the response should come ASAP.

Kate, how many such requests may be expected during "normal" browser usage?  If it would too many (>10) in close parallel burst we might need to add better logic here.
Flags: needinfo?(kmckinley)
Attachment #8842414 - Flags: review?(kmckinley)
I don't have exact numbers, however, I can think of at least one example where more than 10 domains are loaded in parallel/close succession.

I think it is a common case for media sites that may use multiple hostnames to serve up content that when loaded over https, images or other subresources are loaded via http:// from multiple domains. One example would be https://deviantart.com. If loaded over https://, many of the resources are loaded over http:/// from various subdomains of deviantart.net. User created images, for example, can be loaded from any of at least 15 different domains (t01 to t15 . deviantart.net).
Flags: needinfo?(kmckinley)
(Assignee)

Comment 3

2 years ago
(In reply to Kate McKinley [:kmckinley] from comment #2)
> I don't have exact numbers, however, I can think of at least one example
> where more than 10 domains are loaded in parallel/close succession.
> 
> I think it is a common case for media sites that may use multiple hostnames
> to serve up content that when loaded over https, images or other
> subresources are loaded via http:// from multiple domains. One example would
> be https://deviantart.com. If loaded over https://, many of the resources
> are loaded over http:/// from various subdomains of deviantart.net. User
> created images, for example, can be loaded from any of at least 15 different
> domains (t01 to t15 . deviantart.net).

Thanks.  According the example you gave me I think it's OK to take the patch as is.  We have some limits implemented inside the connection management code that should deal with it.
Comment on attachment 8842414 [details] [diff] [review]
v1

Based on your comment about limits elsewhere, I think this looks good. Also, the example changed within the past few days to load most of those mixed-content resources via https.
Attachment #8842414 - Flags: review?(kmckinley) → review+
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 5

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43a3a3c4f451
Mark HSTS priming requests as urgent start. r=kmckinley
Keywords: checkin-needed

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/43a3a3c4f451
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox52: affected → ---
You need to log in before you can comment on or make changes to this bug.