44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Hi Craig, Eric, so you will find the artwork here: option A: https://drive.google.com/a/mozilla.com/file/d/0B20-0lpP23c0NUlnQW1BSVhGOHM/view?usp=sharing option A PNGs: https://drive.google.com/drive/folders/0B20-0lpP23c0YzB5MTNGUlEyS3c?usp=sharing option B: https://drive.google.com/a/mozilla.com/file/d/0B20-0lpP23c0bkNjdkc1a2l2VlU/view?usp=sharing option A PNG: https://drive.google.com/drive/folders/0B20-0lpP23c0RGo0dlVJOXN6MjQ?usp=sharing Ok so if possible we want to swing a AB test. (if we run into any issues with running a test, option A the fallback) ... Craig shoot me an email if you need anything.
For option B, do you have the original photos at a higher resolution? I think it'll be more practical to position them individually on the page rather than as one big background. See https://www.mozilla.org/about/leadership/ as an example. The images in the Illustrator file are also pretty low resolution and very jaggy. Also, something that has come up in the past: do we have permission to use these photos from the people that appear in them? I'd be most concerned about the ones featuring children. If these are all from Mozilla events where everyone attending gave explicit consent to be photographed we should be in the clear, but if we're at uncertain about any maybe we should use some different photos.
Hey Craig, sorry for the late response here. Natalie the designer is out today (it's a holiday in BC). If we use images from the last two years Mozilla Festival we should be good to go, will update you early Monday.
Craig, I did some digging around photo releases. At this point it's a bit convoluted to identify origins and if a release actually happened. Sad, but let's keep it simple and just ship option A (the non photo option.)
(In reply to jordan from comment #4) > Craig, I did some digging around photo releases. At this point it's a bit > convoluted to identify origins and if a release actually happened. Sad, but > let's keep it simple and just ship option A (the non photo option.) Understood. I'll focus on completing just the one version of the takeover in the next few days.
Hey Craig, I was able to confirm all the photos of people are from Mozfest and everyone signed a release when registering (so we are safe to use the photos for option B.) ... So do you have enough time to build B (you can say no)? and if so regarding the photos do you want them rotated at there respective angles and saved as high res .pngs with transparent backgrounds?
(In reply to jordan from comment #6) > Hey Craig, I was able to confirm all the photos of people are from Mozfest > and everyone signed a release when registering (so we are safe to use the > photos for option B.) ... So do you have enough time to build B (you can say > no)? and if so regarding the photos do you want them rotated at there > respective angles and saved as high res .pngs with transparent backgrounds? I think we can still squeeze in the B version. I just need the high-res photos cropped and colored as you want them but NOT rotated, no borders, no drop-shadows etc, just the pictures. All the positioning and shadows etc I'll do with CSS.
Ok awsome Craig. You will find the highres images here: https://drive.google.com/drive/folders/0B20-0lpP23c0c1ROSHRHQjFiNkU?usp=sharing
Hey Eric and Craig. Question about localization. Last year we did not localize the takeover. Mozilla.org is now localized I believe. Is it possible to do the same for the takeover? In addition to language we also use local currency on the donation form, for example https://donate.mozilla.org/de/ defaults to Euro. Is this possible? Sorry to ask about this late in the game, was just brought to my attention.
FYI we can have the necessary strings translated if needed.
(In reply to jordan from comment #9) > Hey Eric and Craig. Question about localization. Last year we did not > localize the takeover. Mozilla.org is now localized I believe. Is it > possible to do the same for the takeover? In addition to language we also > use local currency on the donation form, for example > https://donate.mozilla.org/de/ defaults to Euro. Is this possible? Sorry to > ask about this late in the game, was just brought to my attention. Just to add on that, we have those data here for the donate website: https://github.com/mozilla/donate.mozilla.org/blob/master/src/data/locale-data.js https://github.com/mozilla/donate.mozilla.org/blob/master/src/data/currencies.js If it’s too late, it might be something to consider for next year, if we’re doing the takeover again. But if it’s still doable, that would be great to have. > FYI we can have the necessary strings translated if needed. If we’re going to localize the takeover, it will be translated following the usual mozilla.org process, nothing specific is required. The challenge here is about showing default currencies/pressets, and adding a currency dropdown.
We're not able to do this in the time allotted before 12/1 launch. We can and will pick this up after Hawaii with the intent to We
sorry, didn't intend to submit that just yet: We're not able to do this extra localization ask in the time allotted before 12/1 launch. We WILL launch on Dec 1 w. the A/B test in place, to be clear. We can and will pick this localization request up after Hawaii with the intent to take live the week of Dec 19th. Jordan - the usual l10n process will not be fast enough for our needs here: Please provide string translations (we'll be back in touch on those soon)
Eric great. The week 19th sounds reasonable, fundraising picks up towards the end of December so localization will be worth it.
Here is what we can do regarding l10n: - I can set up a .lang file after 12/1, and extract the strings from the en-US template (in coordination with flod and Peiying) - Translations will be done between 12/1 and 12/19 on Pontoon & GitHub. - After Hawaii and until 12/19, currency support is implemented. - Localized versions are shipped on 12/19. Eric, does that sound good to you?
Flod (and his impressive memory) reminded me that we actually localized the takeover last year: Currencies: https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L670-L966 Exposed strings: https://github.com/mozilla-l10n/www.mozilla.org/commit/d94e7914e3b31e8f6546825b2e27610f52dd9b93 So I should be able to revive those translations since this year’s copy is exactly the same.
Théo - sounds good, especially the utterly low barrier for already localized strings.
I hope to have a pull request ready soon and can put the takover onto a demo server to aid l10n. We have a bit of time to get the strings localized before it goes live on 1 December, especially if we can salvage those strings from last year. The part I don't think we can do right away is making the form accept different currencies. That's not impossible, it was just a last minute scope change that I don't think we can squeeze into the schedule before launch. So for the initial launch I believe the page can be translated but the form will only accept donations in $USD like it did last year.
Do we have updated UTM parameters for this? Should we use all the same ones from last year and just update the campaign from "EOYFR2015" to "EOYFR2016"?
Thank you both for the update regarding l10n Craig, no problem, I think it’s fine to launch 12/1 with the translations from last year and a USD form. We can probably reuse the same trick as last year, i.e. localizing the dollar sign: > # Inserts a sum in US dollars, e.g. '$100'. You can localize it, e.g. '%(sum)s €' to display '100 €' > instead of '$100' > ;$%(sum)s > $%(sum)s I will have a look at the strings next week. What do you think would be a realistic date to add the currencies?
Created attachment 8812367 [details] [review] Github pull request https://github.com/mozilla/bedrock/pull/4476
This is up on a demo server. Version A: https://bedrock-demo-craigcook.us-west.moz.works Version B: https://bedrock-demo-craigcook.us-west.moz.works/?v=b We use sessionStorage to show the takeover only once per visit so to see it repeatedly you'll need to open a new tab/window to begin a new session.
Hey Craig, these both look great. Thank you!
(In reply to Craig Cook (:craigcook) from comment #19) > Do we have updated UTM parameters for this? Should we use all the same ones > from last year and just update the campaign from "EOYFR2015" to "EOYFR2016"? Hi Jordan, sorry if this requrest got lost amidst the other comments. Can you verify what UTM parameters we should use for this campaign? Right now I've got it set up with: utm_campaign = EOYFR2016 utm_source = mozilla.org utm_medium = referral utm_content = takeover The main one in question is the campaign ID. Thanks!
Hi Craig, can we change utm_campaign to EOY2016? That's the one we've been using in other channels. If possible, it would also be great to distinguish the different variants in the utm_content tag. For instance, could we have utm_content=takeoverA for variant A and utm_content=takeoverB for variant B? That way we can track the results of the A/B test beyond just click-throughs. Please let me know if there is anything I can help clarify. Thanks. Vojtech
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/3833b27c3c2fa2e2ec62645c4a48e799767056c4 [fix bug 1316375] EOY 2016 fundraiser home page takeover https://github.com/mozilla/bedrock/commit/5ed372939be12aca77d0e2e13ff579d28c219e36 Merge pull request #4476 from craigcook/bug-1316375-EOY2016-fundraiser-home-takeover [fix bug 1316375] EOY 2016 fundraiser home page takeover
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/3364e9c47c9fc8e46a7053f5c1e9eb557e1013df [bug 1316375] Update EOY campaign ID https://github.com/mozilla/bedrock/commit/bea2e94bad1609dc4eff3a3581f960202ca63ec7 Merge pull request #4511 from craigcook/bug-1316375-EOY2016-fundraiser-home-takeover [bug 1316375] Update EOY campaign ID
Craig, per forwarded email from Vojtech - please shut off the test and make variant A 'the' content for the overlay (100%)
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/74317466a4c50bb7484765ca2ea5f0f1dc682cff [bug 1316375] Set a cookie for the EOY takeover Replace sessionStorage with a cookie that expires in 7 days https://github.com/mozilla/bedrock/commit/26e28879b40152914d875bcd8df561c29fed62d8 Merge pull request #4521 from craigcook/bug-1316375-EOY2016-fundraiser-home-takeover [bug 1316375] Set a cookie for the EOY takeover
The traffic cop switch has been turned off in production so 100% of visitors should be getting the A version. The B version can still be seen at https://www.mozilla.org/?v=b but we're no longer redirecting anyone to that URL automatically.
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/4f335a260a3c4b335a525fbc2ab801a1cf86461b [bug 1316375] Remove EOY2016 fundraising takeover https://github.com/mozilla/bedrock/commit/c558bfa830f2069a39de5ea2a2fe63b654b18744 Merge pull request #4554 from craigcook/bug-1316375-EOY2016-fundraiser-home-takeover [bug 1316375] Remove EOY2016 fundraising takeover